Closed Bug 420437 Opened 16 years ago Closed 6 years ago

Search and emphasize quoted strings with spaces

Categories

(Firefox :: Address Bar, defect)

Product:
Firefox
Component:
Address Bar
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INACTIVE

People

(Reporter: Mardak, Unassigned)

References

Details

Attachments

(2 files)

screenshot of v1
20.17 KB, image/png
beltzner
: ui-review+
Details
v1
5.37 KB, patch
Details | Diff | Splinter Review 
Sometimes it would be useful to do a multi-word search that contains a space. Right now we treat each word separately.
Attached image screenshot of v1 — 

        Attachment #306697 -
        Flags: ui-review?(beltzner)

    
  
Blocks: 405745
Depends on: 407946, 415403

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1
        — 
          — Splinter Review
      

    


  
I'll request review from dietrich and gavin eventually..
Assignee: nobody → edilee
Status: NEW → ASSIGNED

        Attachment #306701 -
        Flags: review?

    
    

    
  
Comment on attachment 306697 [details]
screenshot of v1

Initially I was a little worried about people needing to actually search for page titles with " marks in them, but then I got a grip.

We're basically making the location bar into a full fledged search field, and I totally love it.

uir=beltzner

        Attachment #306697 -
        Flags: ui-review?(beltzner) → ui-review+

    
    

    
  
FYI, searching for """ will find a double quote. Or basically any " not at the front/end of a token.

If you want to try.. https://build.mozilla.org/tryserver-builds/2008-03-01_01:19-edward.lee@engineering.uiuc.edu-keyword.special.string/

    
    

    
  
You need to request review from a specific person.

    
    

    
  
Edward, you did you forget about requesting review from a specific person? :)

    
    

    
  
Comment on attachment 306701 [details] [diff] [review]
v1

clearing review request - patch no longer applies

        Attachment #306701 -
        Flags: review?
Assignee: edilee → nobody
Status: ASSIGNED → NEW

    
    

    
  
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: