415424 - Multiple "Add new engine" options in search bar dropdown list if page is reloaded in the background and advertised engine name changes

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect, P4)

Description

[tabmix.onemen]

Attachment: screenshot

Multiple Add "new engine" in Search button drop down list

Reproducible: Always

Steps to Reproduce:
1.load page with search engine, or this page (oo... you are already here )
2.open more tab(s)
3.select one of the other tab
4 reload this tab using tab context menu.
5.repeat step 4.
6.select this tab again.
7.look in Search button drop down list

Actual Results:
Multiple Add "new engine" in Search button drop down list for the same engine

Expected Results:
one Add "new engine" in Search button drop down list for each engine

Reason for this result:
we only do >> gBrowser.mCurrentBrowser.engines = null in  nsBrowserStatusHandler.prototype.startDocumentLoad

maybe we need to add to tabbrowser.xml mTabProgressListener.onStateChange

-                if (aWebProgress.DOMWindow == this.mBrowser.contentWindow)
+                if (aWebProgress.DOMWindow == this.mBrowser.contentWindow) {
                   this.mBrowser.userTypedClear += 2;
+                  if (aRequest)
+                    this.mBrowser.engines = null;
+                }

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Good catch! It might just be easier to have BrowserSearch.addEngine only add an engine if it isn't already in the list.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Bug 417143 "fixed" this by not adding multiple entries with the same name. I suppose it could still happen if a page advertises a different engine name each time it loads.

Comment 4

[Abhinav Singhal]

I want to slove this bug. Please tell me the procedure.

Comment 5

[Mike Hoye [:mhoye]]

Abhinav - are you still interested in pursuing this bug?

Comment 6

[Mark Banner (:standard8)]

This WFM in the latest Firefox nightly, I suspect we fixed it along the way somewhere.