Closed
Bug 415585
(fx3-l10n-el)
Opened 18 years ago
Closed 17 years ago
Firefox 3 el release tracker
Categories
(Mozilla Localizations :: el / Greek, defect)
Mozilla Localizations
el / Greek
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: pkst)
References
Details
Attachments
(1 file)
1018 bytes,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
This is a tracker bug for releasing Firefox 3 el.
This bug is not that detailed, but as we get particular work items, they should block this bug for tracking, and better discoverability.
Comment 1•17 years ago
|
||
Kostas
will you be making any changes to the search plug-ins, live bookmark or RSS readers?
Assignee | ||
Comment 2•17 years ago
|
||
Yes,
I would like to change the default English live bookmark ( http://newsrss.bbc.co.uk/rss/newsonline_world_edition/front_page/rss.xml ) with the Greek news rss from google (http://news.google.gr/nwshp?hl=el&tab=wn&output=rss) in order to provide local news (unfortunately BBC world servide does offers any more news in Greek).
Is this possible?
Comment 3•17 years ago
|
||
yes, totally, moving this discussion comment 1 and 2 to another bug for web services, will block this bug
Comment 4•17 years ago
|
||
clarifying yes in comment #3 above, yes = we can do this as we want local language live bookmark and we do not need explicit permission from google for this news feed so we are good to go
Reporter | ||
Comment 5•17 years ago
|
||
There is no dedicated web-services bug for Greek, I assume we're going with en-US defaults for now? If so, we'd probably still need yahoo mail to be included in region.properties.
Whiteboard: needs-mic, needs-patch
Assignee | ||
Comment 6•17 years ago
|
||
(In reply to comment #5)
> There is no dedicated web-services bug for Greek, I assume we're going with
> en-US defaults for now?
Yes en-US defaults are fine...
>If so, we'd probably still need yahoo mail to be
> included in region.properties.
OK .. Added yahoo mail (http://l10n.mozilla.org/buildbot/changes/7594 ) in region.properties
Updated•17 years ago
|
Whiteboard: needs-mic, needs-patch → needs-patch
Reporter | ||
Comment 7•17 years ago
|
||
As mentioned in the comment, you need to bump the defaultHandlersVersion when making changes, otherwise they won't get picked up.
Assignee | ||
Comment 8•17 years ago
|
||
Is this OK?
Reporter | ||
Comment 9•17 years ago
|
||
Comment on attachment 314522 [details] [diff] [review]
region-properties
Post-mortem review. Patches like this, and the yahoo fix, should really be reviewed before checking in, that would have caught this bug.
Attachment #314522 -
Flags: review+
Assignee | ||
Comment 10•17 years ago
|
||
(In reply to comment #9)
> (From update of attachment 314522 [details] [diff] [review])
> Post-mortem review. Patches like this, and the yahoo fix, should really be
> reviewed before checking in, that would have caught this bug.
>
Actually el/region-properties is exactly the same as en-US/region-properties. Why I should add more "noise" asking for a review? Ideally, compare-locales should catch the missing yahoo strings (but this would cause problems to other locales) (and if I was more carefull reading the comment for bumping the defaultHandlersVersion ...)
Anyway, sorry for the trouble..
Kostas
Reporter | ||
Comment 11•17 years ago
|
||
FIXED, we shipped with fx 3.0.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: needs-patch
You need to log in
before you can comment on or make changes to this bug.
Description
•