428010 - Web services changes for Firefox 3 for Greek (el)

Status: RESOLVED FIXED

(Mozilla Localizations :: el / Greek, defect)

Description

[Mic Berman]

please add wikipedia per bug 380785. please use wikipedia greek version

also confirming search engines no change: google, yahoo, answers, amazon, CC, eBay

while this is late in the game it might be better to swap eBay.com for eBay.co.uk, same with Amazon (i'd think with proximity to england those would be better?). if it's too late so be it

rss readers no change; google, yahoo, bloglines
mailto needs to be yahoo!mail for now
webcal needs to be 30 boxes for now due to bug 413630

no change to to RSS feed

Comment 1

[Mic Berman]

here are some instructions for adding wikipedia

Search is all (*) in browser/searchplugins. Task: Replace en.wikipedia.org with
el.wikipedia.org. So, first, we need a plugin for the latter, for which a good
name will be wikipedia-el.org. You should create this by following what we do
for en-US closely, that one is at
http://mxr.mozilla.org/mozilla/source/browser/locales/en-US/searchplugins/wikipedia.xml.
Use that as a template, and change the Urls accordingly, and use the link title of the rel="search" link on your wikipedia site as ShortName. That matches what the site sends, so
Firefox will detect that it already has the search plugin.
So, now you have the plugin in el/browser/searchplugins/wikipedia-el.xml, and
to get it picked up, you replace the wikipedia with wikipedia-el in list.txt.

To create the patch, do, in browser/searchplugins
cvs add wikipedia-el.xml
cvs -z3 diff -uN

and attach the output here, and mark it as patch, there's a checkbox for that.
To request review on that, set the "Review" flag to '?', and the requestee to
my bugzilla ID.

(*) The search ordering stuff is in region.properties, too, but that's changed
rarely.

Comment 2

[Kostas Papadimas]

Attachment: wikipedia-el patch for el/searchplugins

Comment 3

[Kostas Papadimas]

(In reply to comment #0)
> please add wikipedia per bug 380785. please use wikipedia greek version
> 
> also confirming search engines no change: google, yahoo, answers, amazon, CC,
> eBay
> 
> while this is late in the game it might be better to swap eBay.com for
> eBay.co.uk, same with Amazon (i'd think with proximity to england those would
> be better?). if it's too late so be it
> 
> rss readers no change; google, yahoo, bloglines
> mailto needs to be yahoo!mail for now
> webcal needs to be 30 boxes for now due to bug 413630
> 
> no change to to RSS feed
> 

* yahoo!mail and webcal are already fixed in el/region-properties
*  The change in ebay and amazon, should be made in list.txt right (simply replacing "ebay" with "ebay-uk" and "amazondotcom" with "amazondotcom-uk)? Or the respective xmls should be added in the el/searchplugins directory?

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 314613 [details] [diff] [review]
wikipedia-el patch for el/searchplugins 

The ShortName should be "Βικιπαίδεια (el)", the rest is looking good.

With that, r=me, please check in with a comment referencing this bug and my review. "me" used to be me, Mic copied over a paragraph I wrote in another bug ;-)

Comment 5

[Axel Hecht [:Pike]]

For ebay.co.uk and amazon.co.uk, the best thing to do is to copy over the plugins from en-GB, those are at http://mxr.mozilla.org/l10n/source/en-GB/browser/searchplugins/, and adjust list.txt again.

Comment 6

[Kostas Papadimas]

Attachment: patch for repacing default ebay and amazon, with ebay.co.uk and amazon.co.uk

Comment 7

[Kostas Papadimas]

Attachment: patch for repacing default ebay and amazon, with ebay.co.uk and amazon.co.uk

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 314641 [details] [diff] [review]
patch for repacing default ebay and amazon, with ebay.co.uk and amazon.co.uk

Mic and I had a little chatter about this offline. To give some context, for user migrating from Firefox 2 to 3, this will mean they'll end up with both the US and UK versions of the two plugins. New users to Firefox 3 will only see the UK versions. Still we think that the UK versions provide a value, in particular in terms of shipping cost, so let's add them.

Migrating users will end up with both as we don't have a locale-specific list of files to remove during upgrade, and we can't remove the en-US ones across all locales, of course :-)

With that background information, r=me.

Comment 9

[Kostas Papadimas]

OK both patches commited

Comment 10

[Axel Hecht [:Pike]]

Yes, FIXED, thanks.

Reference is http://hg.mozilla.org/users/axel_mozilla.com/l10n-src-verification/index.cgi/file/338d198d215d/reference/HEAD/el/.

Comment 11

[Axel Hecht [:Pike]]

Actually, make that http://hg.mozilla.org/users/axel_mozilla.com/l10n-src-verification/index.cgi/file/ecd867aa398e/reference/HEAD/el/, missed a file.