Closed
Bug 415791
Opened 16 years ago
Closed 15 years ago
Page jumps (scrolls) to the focused element when closing a panel
Categories
(Toolkit :: UI Widgets, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta1-fixed |
People
(Reporter: broedli, Assigned: dao)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.10 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8.1.10) Gecko/20071115 Iceweasel/2.0.0.10 (Debian-2.0.0.10-0etch1) Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008020509 Minefield/3.0b4pre If you have a focused link outside the visible area, the page jumps after closing the bookmark dialog. Reproducible: Always Steps to Reproduce: 1. Visit http://www.mozilla.org/about/ 2. Set focus on the link "mission" (f.g.: open it in a new tab) 3. Scroll down until the link is outside the visible area 4. Open the bookmark dialog ("Bookmark this page", Star) 5. Close the bookmark dialog ("Close", click outside) Actual Results: 1. The page jumps until the link is in the visible area This problem occurs also under Windows XP. Regression range: 20080123_1410_firefox-3.0b3pre.en-US.linux-i686.tar.bz2 works 20080123_1600_firefox-3.0b3pre.en-US.linux-i686.tar.bz2 fails http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1201126200&maxdate=1201132799 During the time range was only one checkin, so this must be a regression from Bug 407359.
Reporter | ||
Updated•16 years ago
|
Reporter | ||
Comment 1•16 years ago
|
||
The problem is not restricted to focused links, i can also reproduce it with other focused elements, for example dropdown lists, buttons and text fields.
Comment 2•16 years ago
|
||
confirmed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008020708 Firefox/3.0.0.0 ID:2008020708
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•16 years ago
|
Component: Bookmarks → General
Product: Firefox → Core
QA Contact: bookmarks → general
Reporter | ||
Comment 3•16 years ago
|
||
I requested blocking1.9? because i think it should be marked as wanted1.9+. It's quite annoying to lose the focus on a text passage if you read a long page.
Flags: blocking1.9?
Comment 4•16 years ago
|
||
Not going to block 1.9, but will block 1.9.0.x.
Flags: wanted1.9.0.x+
Flags: blocking1.9?
Flags: blocking1.9-
Reporter | ||
Updated•16 years ago
|
Summary: Page jumps to the focused link after closing the bookmark dialog → Page jumps to the focused element after closing the bookmark dialog
Updated•15 years ago
|
Summary: Page jumps to the focused element after closing the bookmark dialog → Page jumps (scrolls) to the focused element after closing the bookmark dialog/panel
Updated•15 years ago
|
Flags: blocking1.9.2?
Flags: blocking1.9.1?
Comment 6•15 years ago
|
||
I lied.
Comment 8•15 years ago
|
||
--> Core::Disability APIs David, can you look into this and see where the regression is coming from (see comment 0 for blame infoz!)
Component: General → Disability Access APIs
QA Contact: general → accessibility-apis
Comment 9•15 years ago
|
||
IIRC, this was done on purpose, to give screen reader users the previous location back before the Add Bookmarks panel was opened.
Comment 10•15 years ago
|
||
Yes, are we sure this is a bug? (If so, I'm guessing a likely suspect is http://bonsai.mozilla.org/cvsview2.cgi?command=DIFF&subdir=mozilla%2Faccessible%2Fsrc%2Fbase&file=nsRootAccessible.cpp&rev1=1.251&rev2=1.252&whitespace_mode=show&diff_mode=full)
Comment 11•15 years ago
|
||
Of course this is a bug. Switching from another application to Firefox doesn't scroll, so a panel going away shouldn't scroll either. If screen readers are being buggy in this situation (because the panel isn't a full "window" or whatever), the workaround should be limited to the case where a buggy screen reader is active.
Assignee | ||
Updated•15 years ago
|
Component: Disability Access APIs → XUL Widgets
Product: Core → Toolkit
QA Contact: accessibility-apis → xul.widgets
Assignee | ||
Updated•15 years ago
|
Summary: Page jumps (scrolls) to the focused element after closing the bookmark dialog/panel → Page jumps (scrolls) to the focused element when closing a panel
Assignee | ||
Comment 13•15 years ago
|
||
Assignee: nobody → dao
Attachment #382839 -
Flags: review?(enndeakin)
Updated•15 years ago
|
Attachment #382839 -
Flags: review?(enndeakin) → review+
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 14•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/187eddc24c00
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Comment 15•15 years ago
|
||
Marking status1.9.2:beta1fixed since the patch landed before branch.
status1.9.2:
--- → beta1-fixed
Flags: blocking1.9.2? → blocking1.9.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•