415831 - tinderbox should upload to tinderbox-builds dir on clobber

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect, P3)

Description

[Robert Helmer [:rhelmer]]

We're not getting perf test results for clobber builds, but Talos is reporting as if we are.

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: untested, always push to tinderbox-builds dir

I don't like duplicating here, but can't think of a good way to make the intent clear in a loop. I think it'd be better to do this inside pushit() since it knows if it's $cachebuild is set or not, but that function already has a huge mess of conditions.

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 301593 [details] [diff] [review]
untested, always push to tinderbox-builds dir

Nick points out that this will create a full dated dir in the tinderbox-builds dir, I'm just going to bite the bullet and make pushit do the right thing here.

Comment 3

[Robert Helmer [:rhelmer]]

So upon further discussion, maybe it'd be better to just make Talos (or anything else) follow the binaryurl, rather than upload this to both locations.. this upload method is a mess and this surely won't make it better.

Any thoughts? 

Comment 4

[Rob Campbell [:rc] (:robcee)]

if this is what it's come to, then we can do the patch on the talos side to retrieve binaryURL if available. We will transport the mess elsewhere!

Comment 5

[Robert Helmer [:rhelmer]]

(In reply to comment #4)
> if this is what it's come to, then we can do the patch on the talos side to
> retrieve binaryURL if available. We will transport the mess elsewhere!

Honestly I think that's probably the right thing to do here, instead of shoveling stuff into the dir that's supposed to be used for depend builds only (or at least conventionally always has been).