415932 - Remove Bookmark button can disappear when clicking the Places star

Status: VERIFIED DUPLICATE of bug 432599

(Firefox :: Bookmarks & History, defect, P3)

Description

[Steve England [:stevee]]

Attachment: Shows the star UI without a Remove Bookmark button

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008020604 Minefield/3.0b4pre ID:2008020604

1. New profile, start firefox
2. Double-click on the star so it goes gold and the UI appears, then pause for a microsecond and then click the star once more.

Expected:
- the UI is dismissed

Actual:
- the UI remains, but the Remove Bookmark button disappears.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

STR that work reliably for me:

 - go to a page that isn't bookmarked
 - click once to bookmark it
 - double-click
 - you get the dialog without the [Remove Bookmark]

Comment 2

[Tracy Walker [:tracy]]

third click on the star should dismiss the dialog.  wfm on Mac nightly.

Comment 3

[Mike Connor [:mconnor]]

WFM on current trunk.  Please retest and renom if there's better STR than beltzner's.

Comment 4

[mmortal03]

(In reply to comment #3)
> WFM on current trunk.  Please retest and renom if there's better STR than
> beltzner's.
> 

I can reproduce it in the latest hourly, even in safe mode.  I don't see how it could possibly be WFY.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008032811 Minefield/3.0pre ID:2008032811

STR that work reliably for me:

 - go to a page that isn't bookmarked
 - click once on the star to bookmark it
 - now double-click on the star
 - you get the dialog without the [Remove Bookmark] button

Comment 5

[u88484]

I can also reliably reproduce with all of the above steps.  Mike, just click the star a bunch of times, until the dialog appears without the button, if the above steps don't work.

Comment 6

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008032900 Minefield/3.0pre ID:2008032900

I can still reproduce this too, so renom'ng as requested.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Here are the steps to reproduce this issue:

1. Bookmark a site with Ctr+D or by clicking the star icon
2. Double click the star icon at the special position described below
=> "Remove Bookmark" button is not shown

You have to precisely hit this special position otherwise it cannot be reproduced. Take the middle of the star as the horizontal position and click between the star and the edit panel twice. The "Remove Bookmark" button will be shown for a split second and removed afterwards.

It seems to look like that the current state isn't observed and Firefox accidentally think that the site has to be bookmarked. So the initial dialog from step 1 above is shown.

I'm not able to reproduce it under OS X because the panel is positioned a bit higher and I cannot reach the described position.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Not sure that this blocks, but I will confirm that it only happens on Windows (and maybe Linux) since the double-click on the star on OSX doesn't bring up the dialog at all.

Hopefully it's an easy fix of changing the listener there, maybe?

Comment 9

[7842.9]

I did a test with the function StarUI._doShowEditBookmarkPanel (http://mxr.mozilla.org/seamonkey/source/browser/base/content/browser-places.js#164), and found that this._batching is false on the first click on a yellow star, and true on the second click, making the Remove Bookmark button disappear because its hidden property is set to this._batching (http://mxr.mozilla.org/seamonkey/source/browser/base/content/browser-places.js#189).

The function unconditionally calls this.beginBatch() (http://mxr.mozilla.org/seamonkey/source/browser/base/content/browser-places.js#195) which sets this._batching to true. Commenting out this line seems to fix the bug (and didn
t seem to break anything), but I'm not sure if that's the real fix.

Comment 10

[7842.9]

(In reply to comment #9)

Sorry for bugspam, did not find bug 432599 first (which has a patch). Maybe this and bug 421796 should be duped to bug 432599?

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ehsan, will this issue also be fixed with your path on bug 432599?

Comment 13

[(no longer active)]

(In reply to comment #12)
> Ehsan, will this issue also be fixed with your path on bug 432599?

Yeah, in fact, they are reporting the same issue.  I should have found this one before filing bug 432599.  But since I have a patch with r+ on that bug, is it OK to resolve this as a dupe of bug 432599?

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes we should.

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified dup

Comment 16

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv