415934 - Add-on Manager transparent in SeaMonkey's Modern Theme

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Stefan [:stefanh]]

SeaMonkey trunk, Mac OS 10.5.1

STR:

1) Launch SeaMonkey and switch to Modern theme (Tools --> Add-on Manager) if you're not using it.

2) Open the Add-on Manager (Tools --> Add-on Manager)

--> Ask yourself where the Add-on Manager is. Well, there is a title bar and a resizer - but nothing else.


DOMi tells me the window gets background-color rgb(199, 208, 217) from line 61 in suite/themes/modern/global/global.css 

DOMi also tells me that the computed style for the window is rgb(199, 208, 217)

Note: I haven't got a regression range, but I naturally suspect bug 307204. I'm throwing this in widget:cocoa because I think it can be a general issue that can affect other themes. No idea what's going on, unfortunately.

Comment 1

[Stefan [:stefanh]]

Attachment: Screenshot

Comment 2

[Håkan Waara]

Can you find out if it worked before transparent windows landed, and whether it stopped working in the first build with that fix checked in?

Comment 3

[Stefan [:stefanh]]

Sure. Too bad there are no seamonkey nightly builds available from that time, so I have to do a pull. Now, when I think of it, Proto could be the cause of this. I'll get back when I know more.

Comment 4

[Stefan [:stefanh]]

So, this is not transparent windows fault - this works in a trunk build from 2008012601. This is probably not the right component either. I'll investigate further. Anyway, sorry Håkan - my gut feeling was kind of wrong here...

Comment 5

[Håkan Waara]

Could it be that the size is just very off (0 in height)?

Comment 6

[Stefan [:stefanh]]

The resizer is there, if you look at the screenshot and you can resize the window... It looks related to proto since this started to happen the day after proto landed (just checked). Dunno how, though.

Comment 7

[Stefan [:stefanh]]

Hmm...

toolkit/themes/pinstripe/mozapps/extensions/extensions.css:
  1 #extensionsManager {
  2   -moz-binding: url("chrome://global/skin/globalBindings.xml#unifiedWindow");

I haven't understood why yet, but removing the binding will make it work again... afaik the binding doesn't exists in Modern, so bad things probably happens.

Moving this to a better place...

Comment 8

[Stefan [:stefanh]]

Attachment: Hack Modern's globalBindings.xml

Neil had an idea that we could add a bogus binding in Modern's globalBindings.xml. It works. This is enough for solving this bug, I think. Well, the window looks terrible, of course - but that can be solved by styling it in Modern. Once the appropiate files exists for Modern, the binding can be removed.

Comment 9

[Philip Chee]

What does this do in pinstripe anyway?

<http://lxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/global/globalBindings.xml#9>
  <binding id="unifiedWindow">
    <content titlebarcolor="#C4C4C4"/>
  </binding>

Comment 10

[:Gavin Sharp [email: [e-mail]]]

It sets the titlebar color for all windows... you'd have to ask Mano or cbarrett for details, I guess.

Comment 11

[Stefan [:stefanh]]

Comment on attachment 301922 [details] [diff] [review]
Hack Modern's globalBindings.xml

Thinking of it, this might not be the best solution as this unify the window.

Comment 12

[Stefan [:stefanh]]

I don't have any other ideas atm. We could do the binding hack for a temporary solution and live with the fact that it'll be unified, I guess.

Comment 13

[Stefan [:stefanh]]

So, I was a bit distracted when I looked at the window with the hack applied. When I looked at the screenshot Neil had asked for it kind of struck me that the window is not unified with the patch applied. I should probably learn something from this (like, don't talk before you've looked at things carefully).

Comment 14

[[e-mail]]

Comment on attachment 301922 [details] [diff] [review]
Hack Modern's globalBindings.xml

Actually I'm a little surprised that the lack of a binding has such a big effect in this case... I wonder whether this is a bug that bz has heard of.

Comment 15

[Stefan [:stefanh]]

Checking in suite/themes/modern/global/globalBindings.xml;
/cvsroot/mozilla/suite/themes/modern/global/globalBindings.xml,v  <--  globalBindings.xml
new revision: 1.57; previous revision: 1.56
done

Comment 16

[Stefan [:stefanh]]

Filed bug 416219 for the issue with Modern missing skin files for mozapps.