Closed Bug 415956 Opened 16 years ago Closed 16 years ago

Unifinder is always sorted by event title after startup (not as expected)

Categories

(Calendar :: Calendar Frontend, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: Fallen)

References

Details

(Keywords: regression)

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/2008020521 Calendar/0.8pre

Unifinder is always sorted by event title after startup (not as expected)

Steps to Reproduce:
1. Start Sunbird with new clean profile
2. Create some events with different date and title in the near future
3. Sort events by Start date
4. Restart Sunbird

Actual Results:
The Start date column displays the little arrow that indicates the sort order. But the events are sorted by Title column instead.

Expected Results:
Events are sorted by Start date.
Confirming for Lightning 2008020719 on WinXP.
Blocks: 415478
Taking, patch is imminent.
Assignee: nobody → philipp
Attached patch Remember sortingSplinter Review
Attachment #303093 - Flags: review?(Berend.Cornelius)
Status: NEW → ASSIGNED
Version: Trunk → unspecified
This fix is certainly a very good improvement in several aspects:
-Besides that I could see that your modifications around "refreshEventTreeInternal()" improves the performance - especially with many events involved - tremendously probably making a fix for "Bug 415442 – Sunbird consumes much cpu time".
-The sorting problem is fixed,too...
-I noticed that we use a locale-collator in the unifinder for sorting but in the other tasktrees we don't. Couldn't you just make the collator global by introducing a method in calUtils "getLocaleCollator()" that we then use for all; or even offer one "compareString()" method for everybody and ensure that this is used from the other taskrees?
Attachment #303093 - Flags: review?(Berend.Cornelius) → review+
Requesting blocking status...
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: blocking-calendar0.8?
Resolution: --- → FIXED
The patch is not yet check in but the bug is fixed?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
We've re-opened this as the patch since it isn't yet checked in.  I'm also going to plus it as it sounds like it is a performance win and isn't a very scary change.

Flags: blocking-calendar0.8? → blocking-calendar0.8+
Whiteboard: [needs checkin]
Keywords: checkin-needed
Whiteboard: [needs checkin]
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: REOPENED → RESOLVED
Closed: 16 years ago16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Checked in latest nightly build 20080217 -> task is fixed and verified.
Status: RESOLVED → VERIFIED
Blocks: 415442
You need to log in before you can comment on or make changes to this bug.