415957 - No focus feedback for all non-native widgets in proto

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Asaf Romano (gone)]

Both the browser-tabstrip and various non-native widget (buttons/menulists in particular, checkboxes too, very likely) has no feedback in proto/new pinstripe. This is extremely annoying in the advanced search UI in the places organizer for example, and regresses out aceessiblility story on mac just to where it was about three years ago...

Comment 1

[Asaf Romano (gone)]

Since both the buttons and the menulists are already not even close to the native ones, I think it'd be just fine to use images for this state too.

Comment 2

[Stephen Horlander [:shorlander]]

Attachment: Example of described problem

Specifically these graphics?

I can't see what you are describing in the tabbar though.

Comment 3

[Dão Gottwald [:dao]]

The tabs have been fixed in bug 417904.

Comment 4

[Mike Connor [:mconnor]]

Kevin, we need your help here...

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

This was in Proto 0.16.1 but it didn't land with the Proto changes. Kevin?

Comment 6

[Kevin Gerich]

I'm pretty sure that now we have focus feedback for controls that accept focus. What are we missing?

Comment 7

[Asaf Romano (gone)]

 * The "views" button within the sidebar

Comment 8

[Asa Dotzler [:asa]]

testing proto .17, it looks like the focus ring around the match case checkbox in the Find toolbar causes the checkbox and label to shift to the right a pixel or two.  other than that, things look pretty good. 

Comment 9

[Kevin Gerich]

(In reply to comment #8)
> testing proto .17, it looks like the focus ring around the match case checkbox
> in the Find toolbar causes the checkbox and label to shift to the right a pixel
> or two.  other than that, things look pretty good. 
>

just uploaded Proto 0.17.2 to AMO which has the fix for the shifty checkbox 

Comment 10

[Asa Dotzler [:asa]]

perfect. Looks great with .17.2

Comment 11

[Kevin Gerich]

fixed by checkin of Proto 0.17 changes - bug 430202

Comment 12

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381