415987 - FREEBUSY decoding does not support comma-separated entries

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Wolfgang Sourdeau]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.8.1.11) Gecko/20071128 Iceweasel/2.0.0.11 (Debian-2.0.0.11-1)
Build Identifier: Lightning 0.7  build 2007102303

While looping with the following code to retrieve the FREEBUSY entries:

var ics = Components.classes["@mozilla.org/calendar/ics-service;1"]
 	.getService(Components.interfaces.calIICSService);
var cal = ics.parseICS(fbText);
var vfb = cal.getFirstSubcomponent("VFREEBUSY");

var done = false;
while (!done) {
  var fb;
  if (count < 1)
    fb = vfb.getFirstProperty("FREEBUSY");
  else
    fb = vfb.getNextProperty("FREEBUSY");
  if (fb) doSomeThingNice...;
  else
    done = true;
}

... "FREEBUSY" properties specified as this:
FREEBUSY;FBTYPE=BUSY:20080206T160000Z/PT1H,20080206T180000Z/PT1H,20080206T
 200000Z/PT1H,20080206T220000Z/PT1H,20080207T000000Z/PT1H

are never found. Instead, I have to work-around this by splitting the value and reinserting corresponding single entries:

FREEBUSY;FBTYPE=BUSY:20080206T160000Z/PT1H
FREEBUSY;FBTYPE=BUSY:20080206T180000Z/PT1H
FREEBUSY;FBTYPE=BUSY:20080206T200000Z/PT1H
FREEBUSY;FBTYPE=BUSY:20080206T220000Z/PT1H
FREEBUSY;FBTYPE=BUSY:20080207T000000Z/PT1H

This looks like there is a bug in the ICS parser...

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Daniel Boelzle [:dbo]]

Attachment: suggested fix in libical

I can imagine this is the same bug that I've fixed with EXDATE/RDATE lists in libical's parser code.
Wolfgang, could you please check out this simple patch whether it fixes your problem?

Comment 2

[Wolfgang Sourdeau]

I don't know if I will have the time to rebuild the package. I'll keep you posted.

Comment 3

[Daniel Boelzle [:dbo]]

Please note that we are right before 0.8 RC1. So it's getting soon harder to get fixes in.

Comment 4

[Wolfgang Sourdeau]

The problem is that I have plenty of work and I am a bit reluctant to uncompress, setup the whole mozilla build environment and build Lightning just to test this.
Would it possible for you to test it instead? I could provide you with an .ifb file which causes the bug and another which doesn't...

Comment 5

[Daniel Boelzle [:dbo]]

Attachment: fix

Fix including a basic unit test.

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 302003 [details] [diff] [review]
fix

Looks good, r=philipp

I'm not sure if there are any implications on changing libical, especially since it is updated on trunk and not on branch?

Comment 7

[Daniel Boelzle [:dbo]]

Comment on attachment 302003 [details] [diff] [review]
fix

r+ per comment #6

Checked in on HEAD and MOZILLA_1_8_BRANCH.

I'll leave a comment in bug 394902 about this bug.