KDE/Gnome startup notification not disappearing when app window is up

RESOLVED FIXED in mozilla2.0

Status

()

Core
Widget: Gtk
RESOLVED FIXED
10 years ago
7 years ago

People

(Reporter: Robert Kaiser, Assigned: wolfiR)

Tracking

({regression})

1.9.1 Branch
mozilla2.0
All
Linux
regression
Points:
---

Firefox Tracking Flags

(status1.9.2 .4-fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
For probably as long as I can remember using 1.9 trunk builds (I guess some time around the switch of SeaMonkey to toolkit), the KDE startup notification (jumping app icon next to the mouse) does not disappear when the (first) app window is open, it only goes way after some timeout. This looks like the desktop never realizes our window is actually up.
Interestingly, this has been working on branch, where we AFAIK don't specifically support the freedesktop startup notification stuff.

Comment 1

10 years ago
I had the same problem:

You need to compile Firefox with the startup-notification library.
(--enable-startup-notification)

Voilà! fixed ;)
Bye.

Comment 2

9 years ago
Why are the binary releases not being compiled with --enable-startup-notification?

This is a problem due to some distro's simply repacking the Mozilla release binaries, e.g., Slackware.
(Assignee)

Comment 3

8 years ago
Probably that bug could be morphed as apparently startup notification on Linux is broken with Gecko 1.9.1. At least I see it non working with FF3.5 in Gnome and KDE even when built with --enable-startup-notification.

What do other people see?
(Reporter)

Comment 4

8 years ago
I never saw it working at least with 1.9.1 on KDE 3.x or 4.x, but I never tried GNOME, all on openSUSE Factory and stable 11.x releases and all with self-compiled builds which have --enable-startup-notification.
(Assignee)

Comment 5

8 years ago
It worked with Firefox 3 but not FF3.5.
Hardware: x86 → All
Summary: KDE startup notification not disappearing when app window is up → KDE/Gnome startup notification not disappearing when app window is up
Version: Trunk → 1.9.1 Branch
(Assignee)

Updated

8 years ago
Keywords: regression

Updated

8 years ago
Duplicate of this bug: 425934
(Assignee)

Comment 7

8 years ago
Created attachment 405030 [details] [diff] [review]
patch f(rom Lubos Lunak)

Patch from Lubos Lunak from downstream bug:
https://bugzilla.novell.com/show_bug.cgi?id=518603

"
The patch fixes it - 'toolkit' was NULL at the old place, only created by the
call to 'CreateHiddenWindow'. I guess the patch is safe and correct.
"
(Assignee)

Updated

8 years ago
Attachment #405030 - Flags: review?(benjamin)
Attachment #405030 - Flags: review?(benjamin) → review+
(Reporter)

Updated

8 years ago
Assignee: nobody → mozilla
(Assignee)

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/1a9b6d37e99a
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3
(Assignee)

Comment 9

8 years ago
Comment on attachment 405030 [details] [diff] [review]
patch f(rom Lubos Lunak)

Pretty low risk for 1.9.2 and solves an annoying visual behaviour on Linux desktops
Attachment #405030 - Flags: approval1.9.2?
(Assignee)

Updated

8 years ago
Flags: wanted1.9.2?
Comment on attachment 405030 [details] [diff] [review]
patch f(rom Lubos Lunak)

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.
Attachment #405030 - Flags: approval1.9.2?
Attachment #405030 - Flags: approval1.9.2?

Updated

8 years ago
Depends on: 534845

Comment 11

8 years ago
I filed Bug 534845, for distros build firefox with --enable-startup-notification, you may also want to get it fixed.
(Reporter)

Comment 12

8 years ago
If this is not being looked at for 1.9.2 right now just for logistical purposes, can we request for it to go straight into 1.9.1 so our current releases work well with KDE?
(Assignee)

Comment 13

8 years ago
Comment on attachment 405030 [details] [diff] [review]
patch f(rom Lubos Lunak)

requesting approval for next possible release.
(cannot cancel the original one for some reason)
Attachment #405030 - Flags: approval1.9.2.1?
Attachment #405030 - Flags: approval1.9.2?

Updated

8 years ago
Attachment #405030 - Flags: approval1.9.2.2? → approval1.9.2.3?
Attachment #405030 - Flags: approval1.9.2.4? → approval1.9.2.4+
Comment on attachment 405030 [details] [diff] [review]
patch f(rom Lubos Lunak)

a=beltzner for 1.9.2.4
(Assignee)

Comment 15

8 years ago
mozilla-1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/965a31dcde02
status1.9.2: --- → .4-fixed
(Assignee)

Updated

8 years ago
Flags: wanted1.9.2?

Comment 16

8 years ago
You need to fix Bug 534845 on 1.9.2 branch to make restart situation work.
Target Milestone: mozilla1.9.3 → mozilla2.0
You need to log in before you can comment on or make changes to this bug.