Closed
Bug 416113
Opened 17 years ago
Closed 17 years ago
cocoa widget does not draw focus rings for xul textboxes
Categories
(Core :: Widget: Cocoa, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta4
People
(Reporter: jaas, Assigned: asaf)
References
Details
Attachments
(1 file)
|
1.50 KB,
patch
|
jaas
:
review+
roc
:
superreview+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
Now that bug 415466 has landed we should be able to draw focus rings around text fields. We don't get focus rings in text fields in preference panes while we do in content.
|
||
Comment 1•17 years ago
|
||
Dupe of bug 415957?
|
Assignee | |
Comment 2•17 years ago
|
||
Hi Josh.
This is a cocoa bug, actually. In XUL documents, -moz-appearance: textbox is set set for the containing box, while focus is still set for the internal textfield (for which -moz-appearance: none; is set). XUL textboxes use the focused attribute for allowing themes (and nsITheme implementations) to draw focus feedback.
Assignee: nobody → joshmoz
Component: Preferences → Widget: Cocoa
Product: Firefox → Core
QA Contact: preferences → cocoa
|
|
Assignee | |
Updated•17 years ago
|
Summary: text fields in preference panes should have focus rings when focused → cocoa widget does not draw focus rings for xul textboxes
|
|
Assignee | |
Comment 3•17 years ago
|
||
Apparently, we already track ::focused in WidgetStateChanged.
|
|
Assignee | |
Updated•17 years ago
|
Flags: blocking1.9?
Priority: -- → P2
Target Milestone: --- → mozilla1.9beta4
Attachment #301968 -
Flags: superreview?(roc)
Attachment #301968 -
Flags: review?(joshmoz)
Attachment #301968 -
Flags: review+
Strictly speaking this wouldn't block, but we should definitely take it as a highly wanted bug.
Flags: wanted1.9+
Flags: blocking1.9?
Flags: blocking1.9-
Attachment #301968 -
Flags: superreview?(roc) → superreview+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #301968 -
Flags: approval1.9?
|
||
Comment 5•17 years ago
|
||
Comment on attachment 301968 [details] [diff] [review]
patch
a1.9+=damons
Attachment #301968 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 6•17 years ago
|
||
mozilla/widget/src/cocoa/nsNativeThemeCocoa.mm 1.78
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•