416197 - Value excerpting only applies to child nodes

Status: RESOLVED FIXED

(Toolkit Graveyard :: Microformats, defect)

Description

[Mike Kaply [:mkaply]]

After lots of discussion on microformats IRC (and finally finding a reference), it appears that the intent of the class="value" design pattern for microformats was that it should only grab children with the class, not descendants.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Fix for problem plus test

After we get the values, go through and make sure they are all immediate children of the node we queried them from.

Comment 2

[Robert Sayre]

Comment on attachment 302861 [details] [diff] [review]
Fix for problem plus test


>+        /* Verify that values are children of the propnode */
>+        for (let i=0; i < values.length; i++) {
>+          if (values[i].parentNode != propnode) {
>+            values.splice(i,1);
>+            i--;
>+          }
>+        }

Pretty nasty looking. I can live with it, but please try to find a prettier way to write this.

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 302861 [details] [diff] [review]
Fix for problem plus test

I did make a change per rsayre's request - I enumerate backwards through the array to avoid the i--. It will be checked in like that.

Comment 4

[Mike Kaply [:mkaply]]

Fix checked in.