Seamonkey/xpfe needs patch for bug 376473

RESOLVED FIXED

Status

Product:
SeaMonkey
Component:
General
RESOLVED FIXED
Reported:
10 years ago
Modified:
10 years ago

People

(Reporter: dveditz, Assigned: Bruno 'Aqualon' Escherl)

Tracking

({fixed-seamonkey1.1.9, fixed1.8.1.13, fixed1.8.1.15})

Version:
SeaMonkey 1.1 Branch
Keywords:
fixed-seamonkey1.1.9, fixed1.8.1.13, fixed1.8.1.15
Bug Flags:
blocking-seamonkey1.1.9 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Increase timeout to 1000
3.05 KB, patch
dveditz
: review+
neil@parkwaycc.co.uk
: superreview+
dveditz
: approval1.8.1.13+
Details | Diff | Splinter Review
(Reporter)

Description

•
10 years ago 
bug 376473 is a way to trick users into clicking various OK dialogs that don't have a sufficient timeout after hiding the dialog and refocusing. It looks like only the Firefox/toolkit versions of those dialogs got patched, Seamonkey 1.1.x has its own versions of commondialog.js and nsHelperAppDlg.js.
Flags: blocking-seamonkey1.1.9+

Updated

•
10 years ago
Depends on: 376473
No longer depends on: 375473

Comment 1

•
10 years ago 
Dan, were you planning to do this? Looks like 1.8.1.13 has been relbranched and we still have no fix for this :(
 (Assignee)

Comment 2

•
10 years ago 
Created attachment 308905 [details] [diff] [review]
Increase timeout to 1000

I ported the patch from bug 376473, but I don't know who can do review here. Robert, can you please set the flags accordingly?
Assignee: general → aqualon
Status: NEW → ASSIGNED

Comment 3

•
10 years ago 
Comment on attachment 308905 [details] [diff] [review]
Increase timeout to 1000

Setting reviewers that fit this bug.

Dan, can we land this on the relbranch as well? that would be easiest for us to deal with. Requesting approval for that branch.
Attachment #308905 - Flags: superreview?(neil)
Attachment #308905 - Flags: review?(dveditz)
Attachment #308905 - Flags: approval1.8.1.13?

Updated

•
10 years ago
Attachment #308905 - Flags: superreview?(neil) → superreview+
 (Reporter)

Comment 4

•
10 years ago 
Comment on attachment 308905 [details] [diff] [review]
Increase timeout to 1000

r=dveditz
Attachment #308905 - Flags: review?(dveditz) → review+
 (Reporter)

Comment 5

•
10 years ago 
Comment on attachment 308905 [details] [diff] [review]
Increase timeout to 1000

approved for 1.8.1.13 relbranch, a=dveditz for release-drivers

Please also land on the 1.8 branch itself, and add _both_ the fixed1.8.1.13 and fixed1.8.1.14 keywords (so your qa can verify it gets fixed in both places)
Attachment #308905 - Flags: approval1.8.1.13? → approval1.8.1.13+

Comment 6

•
10 years ago 
Landed on both the 1.8.13 relbranch and the 1.8 branch, thanks a lot!
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed-seamonkey1.1.9, fixed1.8.1.13, fixed1.8.1.14
Resolution: --- → FIXED
Version: unspecified → SeaMonkey 1.1 Branch
You need to log in before you can comment on or make changes to this bug.