416555 - when sorting by name in the Library put folders before bookmarks

Status: NEW

(Firefox :: Bookmarks & History, defect, P5)

Description

[Marco Bonardo [:mak]]

Attachment: patch

when sorting by name in the Library we are mixing up bookmarks and folders. It would be more useful and common put folders before 

(see also Bug 400474 from where this was spunoff)

Comment 1

[Marco Bonardo [:mak]]

adding uiwanted to be sure this is a wanted change. We are already sorting with folders before when sorting the menu by name so it should be the preferred way of sorting (also for platform conformity)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

That's the way how Firefox 2 is sorting by name. Adding regression keyword.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Low priority blocker to fix the UE regression here, which could be pretty annoying. To clarify, though, when we do this sort, is it permanent or not in terms of ordering the items? I know we've run into that question before, and believe that the solution was that sorting them wouldn't re-order them permanently.

Comment 4

[Marco Bonardo [:mak]]

no, it's not permanent

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As note: This only happens when doing that via the Views menu. Choosing "Sort by name" from within the context menu does the sorting right.

Comment 6

[Marco Bonardo [:mak]]

Attachment: unbitrot

Comment 7

[Mike Connor [:mconnor]]

Not blocking on this bug for final ship. Would take a safe enough patch if one comes through.

Comment 8

[Dietrich Ayala (:dietrich)]

Hrm. I'd prefer to implement a sorting callback, rather than continue to add special-case sorting code to the back-end.

We should use the mechanism in the link below for a new nsINavHistoryQueryOptions.sortingFunction option. That would allow more extensibility and customization, and we can stop chasing use-cases in C++.

http://developer.mozilla.org/en/docs/Creating_JavaScript_callbacks_in_components

Comment 9

[Paul J. Weiss]

Some of us _like_ mixing folders and files in a sort. Can this be made an option?

Comment 10

[Paul J. Weiss]

Is this the same as bug 408775?

Comment 11

[Paul J. Weiss]

And the same as bug 288260?

Comment 13

[Aakash Desai [:aakashd]]

I added the in-litmus flag value "?" to this test case as it's a continuation of bug 400474 which has been verified and fixed (even though the discussion over the fix is ongoing) and its in-litmus flag value was "?".

Comment 14

[Marco Bonardo [:mak]]

due to bug 499985 i'm not sure where this will finish. unassigning for now since not working actively on it.

Comment 15

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 16

[David A. Cobb]

PLEASE only do this if it is a configuration option.  Personally, I don't like the way Windows does this!  I LIKE having folders and bookmarks sorted together.
OK, that's just me; but making it optional shouldn't make it any harder to do.