Closed Bug 416637 Opened 17 years ago Closed 17 years ago

"ASSERTION: Invalid char passed in" with paragraph separator and combining acute accent

Categories

(Core :: Graphics, defect, P2)

x86
macOS
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: jruderman, Assigned: roc)

References

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

Attached file testcase
Loading the testcase triggers: ###!!! ASSERTION: Invalid char passed in: '!gfxFontGroup::IsInvalidChar(aString[firstOffset/2])', file /Users/jruderman/trunk/mozilla/gfx/thebes/src/gfxAtsuiFonts.cpp, line 877 The characters in the testcase are: U+2029, paragraph separator U+0301, combining acute accent
This could probably lead to crazy stuff in the font system
Assignee: nobody → roc
Flags: blocking1.9?
Flags: blocking1.9? → blocking1.9+
Attached patch fixSplinter Review
Simple fix ... even though the combining mark(s) are at the "start of the text", there may be invalid characters before them that we skipped on purpose, so the string might not be at offset 0.
Attachment #303197 - Flags: review?(vladimir)
Whiteboard: [needs review]
Priority: -- → P2
Flags: tracking1.9+ → blocking1.9+
Whiteboard: [needs review] → [needs landing]
checked in with test
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs landing]
Depends on: 421955
verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032615 Firefox/3.0b5pre - no assertion when i load the testcase
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: