416749 - Wrapping fails when line is made up of small blocks of processed (e.g. colored) text

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

If you say %C8YELLO! lots of times without spaces, it wont wrap. We generate lots of <span>s for the colours, but with no space or <wbr> between, they wont wrap.

Proposed solution: add a <wbr> after each styled <span>.

Comment 1

[James Ross]

Note that this is kinda similar to bug 211272, but there I don't think we have an easy way out.

Comment 2

[krishean]

Attachment: possible fix, may need more optomization

Comment 3

[krishean]

Attachment: some test cases

the patch applies to http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/content/mungers.js#652

Comment 4

[krishean]

Attachment: thats not a patch, this is a patch (thanks Mitch)

Comment 5

[krishean]

Attachment: removed some obsoleted code

Comment 6

[James Ross]

Comment on attachment 321314 [details] [diff] [review]
removed some obsoleted code

>+    var wbr = document.createElementNS("http://www.w3.org/1999/xhtml",
>+                                           "html:wbr");

Nit: Line this up.

+	containerTag.appendChild(wbr.cloneNode(true));

Nit: Use 8 spaces, not 1 tab here.

r=silver with those fixed (which I'll do before check-in)

Thanks for the patch!

Comment 7

[James Ross]

Checked in --> FIXED.