416802 - Add additional properties to allow easy customization of days in the views

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Add day relations

Currently, all that is provided in the views as attributes is weekend, today, selected.

This could be extended to give a hint if the day is in the past, today, or future. The attached patch takes care, by replacing the today="true" attribute with a relation="today" attribute, and adding past and future.

This also fixes the CSS style rules in our calendar-views.css. Before, we were specifying:

background: #FFFFFF;

Which does work, but is not quite clean. I changed to the following:

background-color: #FFFFFF;


This doesn't change any UI, but provides possibilities for users as requested in 
http://groups.google.com/group/mozilla.support.calendar/browse_thread/thread/053b9c50b9a771a9

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Add day relations - v2

V2 also adds off-time markers to the time-bar.

With a rule like


.calendar-time-bar-box-odd[off-time="true"],
.calendar-time-bar-box-odd[off-time="true"] {
   background-color: #CC7CCCC;
}

Or alternatively:

.calendar-time-bar-box-odd:not([off-time="true"]),
.calendar-time-bar-box-odd:not([off-time="true"]) {
   background-color: #CC7CCCC;
}

The time bar box can be modifed.

Comment 2

[Stefan Sitter [:ssitter]]

I like the idea. It allows to customize the views e.g. as requested in <http://forums.mozillazine.org/viewtopic.php?t=628526> (cross off past days like in a paper calendar). The following shows the result of this patch, a handmade semi-transparent image and two lines of userChrome.css rules: http://img207.imageshack.us/img207/430/bug416802vv4.png

Comment 3

[Bas van den Bosch]

I like this too, this should make advanced configuration imho. The transparant image of a cross could then be included in the default package. It should be css-placed in the centre of the dayblock then as we want to be able to resize these blocks. The configuration should be able to detect wether a filename for an image is given or a color. All imho of course :-)

Comment 4

[Berend Cornelius]

The patch works fine. 

>+                  switch (d.compare(today)) {
>+                      case -1:
>+                          dayHeaderBox.setAttribute("relation", "past");
>+                          dayEventsBox.setAttribute("relation", "past");
>+                          break;
>+                      case 0:
>+                          dayHeaderBox.setAttribute("relation", "today");
>+                          dayEventsBox.setAttribute("relation", "today");
>+                          break;
>+                      case 1:
>+                          dayHeaderBox.setAttribute("relation", "future");
>+                          dayEventsBox.setAttribute("relation", "future");
>+                          break;
>+                  }
Couldn't this be set up in a commonly used function as you are using it in a similar war at another place?
Thank you!

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

It probably could, but given the short schedule I'll leave it in until its needed more than twice.

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED