417086 - Use of colon (:) in hash/anchor part of chrome URL when using window.open results in an error.

Status: RESOLVED FIXED

Description

[karl]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12

If an add-on attempts to open a chrome URL in a new window and the hash part of the URL contains a colon character (:) then an error is throw and the window doesn't open


Reproducible: Always

Steps to Reproduce:
1.Open Error console
2.Enter "window.open('chrome://mozapps/content/extensions/extensions.xul#a:')" in the Code textbox
3.Hit "Evaluate".
Actual Results:  
Error thrown
Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMJSWindow.open]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: javascript:%20window.open("chrome://mozapps/content/extensions/extensions.xul#a:") :: <TOP_LEVEL> :: line 1"  data: no]

Expected Results:  
A new window should open, displaying "chrome://mozapps/content/extensions/extensions.xul"


The fact that the anchor doesn't exist on the page (or is invalid) should not prevent the window from opening and the "chrome://mozapps/content/extensions/extensions.xul" page being displayed.

This bug is NOT PRESENT in firefox 2.0.0.11 (or FF 3.0b2), only in 2.0.0.12 (also FF 3.0b4pre)

bug #415367 (https://bugzilla.mozilla.org/show_bug.cgi?id=415367) (fixed?) is very similar, but only affects the query part of the URL.

If the URL is pasted into the address bar (and then [enter] hit) then nothing happens (no error is throw, but browser doesn't navigate to URL either). Is the error message suppressed?

If the colon (:) is removed from the URL (chrome://mozapps/content/extensions/extensions.xul#a) all works as expected.

Comment 1

[Daniel Veditz [:dveditz]]

Missed the ref in bug 415338, although this seems a very strange thing to do with chrome. I guess something like chrome help content could have anchors.

Comment 2

[Daniel Veditz [:dveditz]]

Created attachment 302967 [details] [diff] [review]
ignore chrome #ref as well

Comment 3

[karl]

The reason for the error occured was because I was passing a URL to the chrome page when opening it (eg chrome://example/content/example.html#url=https://bugzilla.mozilla.org/show_bug.cgi?id=417086)

I was using the anchor part of the URL to pass additional arguments to the page.
I really should have been using the query part of the URL. But was unsure how firefox would handle a chrome URL with a query string.

chrome://example/content/example.html?url=https://bugzilla.mozilla.org/show_bug.cgi?id=417086

Comment 4

[Philip Chee]

ISTR that the 1.8.0 Extension/Theme Manager used query strings to open in either Extension or Theme mode. You might look at that.

Comment 5

[Philip Chee]

Or was that the 1.7 manager?

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 302967 [details] [diff] [review]
ignore chrome #ref as well

approved for 1.8.1.13, a=ss for release-drivers

Comment 7

[Daniel Veditz [:dveditz]]

Fix checked into trunk

Comment 8

[Stephen Donner [:stephend]]

Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.13) Gecko/2008031114 Firefox/2.0.0.13; see

http://img212.imageshack.us/my.php?image=picture2yp7.png

Replacing fixed1.8.1.13 keyword with verified1.8.1.3

Comment 9

[Alexander Sack]

Comment on attachment 302967 [details] [diff] [review]
ignore chrome #ref as well

a=asac for 1.8.0.15

Comment 10

[Reed Loden [:reed] (use needinfo?)]

MOZILLA_1_8_0_BRANCH:

Checking in chrome/src/nsChromeRegistry.cpp;
/cvsroot/mozilla/chrome/src/nsChromeRegistry.cpp,v  <--  nsChromeRegistry.cpp
new revision: 1.338.2.1.4.7; previous revision: 1.338.2.1.4.6
done
Checking in rdf/chrome/src/nsChromeRegistry.cpp;
/cvsroot/mozilla/rdf/chrome/src/nsChromeRegistry.cpp,v  <--  nsChromeRegistry.cpp
new revision: 1.323.10.5; previous revision: 1.323.10.4
done