417309 - Subscribe to This Page sub menu state doesn't update correctly

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Stefan [:stefanh]]

STR:

1) Start SeaMonkey, go to a page which has feeds
2) Open the Bookmarks menu, note that the menutem is not disabled
3) Go to a page that doesn't have feeds
4) Open the Bookmarks menu, note that the menuitem is not disabled


Now, do the opposite:
6) Quit & Start SeaMonkey, go to a page that doesn't have feeds
7) Open the Bookmarks menu, note that the menuitem is disabled
8) Go to a page that has feeds
9) Open the Bookmarks menu, note that the menuitem is disabled

(DOMi doesn't tells me anything about the disabled attribute here in both cases)

Comment 1

[Justin Wood (:Callek)]

WFM on windows, stefan could you please see if there is any corresponding mac bug.

Comment 2

[Stefan [:stefanh]]

(In reply to comment #1)
> WFM on windows, stefan could you please see if there is any corresponding mac
> bug.
> 

Can't find anything obvious. There are a few bugs, but they're dealing with shortcut keys (bug 382138, bug 363187). And then there's bug 101218 which seems to be wfm for me.

In Firefox, the menuitem updates correctly. So, this must have something to do with how the implementation is done. In what way does this differ from the Firefox implementation?

For the record: I tried without any icon, but the issue is still there (not very likely that removing the icon would change anything, but you never know).

Comment 3

[Justin Wood (:Callek)]

jag, can you confirm; and do you have any ideas?

Comment 4

[Stefan [:stefanh]]

Attachment: Patch to show that this is an issue with the native menu

So, it seems that this is a problem with the widget code not updating a submenu correctly. If I apply this patch and then launch SeaMonkey, the File --> New submenu will not be disabled even though DOMi tells me it is.

Comment 5

[Justin Wood (:Callek)]

stefanh, fixed per Bug 456374?

Comment 6

[Stefan [:stefanh]]

(In reply to comment #5)
> stefanh, fixed per Bug 456374?

Yep, Neil fixed it.