456374 - Can't update / set disabled attribute on native submenu

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Stefan [:stefanh]]

Attachment: test-patch

STR:

1) Apply patch and build
2) Launch Minefield
3) Hit the "Disable Menuitem" and the "Disable Menu" buttons in the statusbar

Expected results: Both "Menuitem" and "Menu" disabled
Actual results: Only "Menuitem" is disabled, even though DOMi tells you that both items are disabled.

Note: If you add the submenu to the Tools menu, you can update/set the attribute - but *only* if you don't open the parent (Tools menu).

Comment 1

[[e-mail]]

Attachment: Proposed patch

I wrote this patch by code inspection but Stefan says that it fixes the bug for him and also fixes the Insert and Format menus in Thunderbird and SeaMonkey's HTML mail composition window.

Comment 2

[Stefan [:stefanh]]

(In reply to comment #1)
> and also fixes the Insert and Format menus in Thunderbird and SeaMonkey's
> HTML mail composition window.

With Neil's patch: If a top-level menu is disabled, it will still appear enabled in the menubar, but all the children will be disabled (you can open the menu but all items in it are disabled).

Comment 3

[Josh Aas]

The patch basically looks good to me but we'll need a test, which means we have to resolve 446352. This is a bug in the lazy updating behavior.

Comment 4

[Josh Aas]

I'm writing the tests necessary for this now.

Comment 5

[[e-mail]]

Pushed changeset fe0fb18e9d72 to mozilla-central.