Closed Bug 417516 Opened 12 years ago Closed 11 years ago

add top level Makefile targets to run test suites

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: ted, Assigned: ted)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 4 obsolete files)

Right now running mochitest or reftest requires knowing an arcane commandline.  We should just have "mochitest" and "reftest" targets in the top level makefile.
Severity: normal → enhancement
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Comment on attachment 327627 [details] [diff] [review]
add "mochitest" target, and targets for each mochitest variant

Ack, hit enter too early. This is a rough draft of a patch that adds a "mochitest" target, to run all the mochitest variants, as well as a target per-variant. It's not terribly useful yet, since it won't error on failure, I don't think.
Attachment #327627 - Attachment description: add → add "mochitest" target, and targets for each mochitest variant
Attachment #327627 - Attachment is patch: true
Attachment #327627 - Attachment mime type: application/octet-stream → text/plain
Attached patch somewhat more complete (obsolete) — Splinter Review
This works for the basic mochitest case. browser-chrome output is different, so it won't work there. I haven't tried the a11y tests yet.

We need to get our test suites on the same page. :-/
Attachment #327627 - Attachment is obsolete: true
Depends on: 443090
Attached patch handles mochitest correctly (obsolete) — Splinter Review
Well now that I've done a bunch of work in bug 443090, this is easier! The runtests.py changes are because I didn't fix that problem for browser-chrome when I fixed it for regular mochitest, apparently.
Attachment #327654 - Attachment is obsolete: true
Comment on attachment 328898 [details] [diff] [review]
handles mochitest correctly

I think this is good to go now.
Attachment #328898 - Flags: review?(benjamin)
Comment on attachment 328898 [details] [diff] [review]
handles mochitest correctly

Are you sure you want to have all of these targets for all products? (aren't the browser-chrome tests Firefox-specific?) If you are, r=me... otherwise maybe we should put that part in browser/build.mk
Attachment #328898 - Flags: review?(benjamin) → review+
Good call, I'll move mochitest-browser to browser/build.mk. The other stuff won't work on a non-browser app, but I do want Firefox and SeaMonkey to both have access.
Made some tweaks and checked this in. Leaving the bug open to handle reftest.
Attachment #328898 - Attachment is obsolete: true
Blocks: 447664
Are these documented somewhere (how to use them)?
No, I didn't get around to that yet. Also apparently I got backed out last night.
vlad found a bug in this, if you run runtests.py without --log-file, it breaks mochitest. That might be what was causing problems yesterday. (Oops!)
Attachment #330976 - Attachment description: [checked in] mochitest targets, as checked in → mochitest targets, as checked in (the first time)
This fixes that stupid oversight in runtests.py. I'll push this when the tree goes green again...
Attachment #330976 - Attachment is obsolete: true
Comment on attachment 331309 [details] [diff] [review]
[checked in] fixed the bug in runtests.py

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/409570e09968
Attachment #331309 - Attachment description: fixed the bug in runtests.py → [checked in] fixed the bug in runtests.py
ted, this resolved or should it stay open?
So far only "make mochitest" is supported. Something like "make reftest" is still missing.
Keywords: dev-doc-needed
Note, documentation should be updated on at least:
https://developer.mozilla.org/En/Mochitest (I partially updated this, but deki is too frustrating for me)
https://developer.mozilla.org/en/Chrome_tests
https://developer.mozilla.org/en/Browser_chrome_tests

Ideally, there should be a single document on running all the kinds of tests we have (aka what to do before checking in).
Waldo filed bug 468913 on reftest, so might as well close this.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Someone has already updated https://developer.mozilla.org/En/Mochitest to cover this.
Target Milestone: --- → mozilla1.9.1b1
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.