Closed Bug 417605 Opened 14 years ago Closed 7 years ago

Change BeOS to invoke improved code

Categories

(Core :: XPCOM, enhancement)

x86
BeOS
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: doug, Assigned: doug)

References

Details

(Keywords: fixed1.8.1.13)

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.12) Gecko/20080209 BonEcho/2.0.0.12
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.12) Gecko/20080209 BonEcho/2.0.0.12

It appears the improved code introduced in Bug 140412 was never tried/tested under BeOS.  I'm opening this bug to track my attempt to build with and test this code.

Reproducible: Always
Assignee: general → nobody
Component: General → XPCOM
Product: Mozilla Application Suite → Core
QA Contact: general → xpcom
Version: unspecified → 1.8 Branch
Attached patch Changes BeOS to use newer code (obsolete) — Splinter Review
Firefox builds and runs using newer code under BeOS (Zeta).
Attachment #303423 - Flags: review?(thesuckiestemail)
Depends on: 140412
Status: NEW → ASSIGNED
Comment on attachment 303423 [details] [diff] [review]
Changes BeOS to use newer code

r=thesuckiestemail@yahoo.se

It would be nice to see what thought any expert on this might have.
Attachment #303423 - Flags: review?(thesuckiestemail) → review+
Assignee: nobody → doug
Status: ASSIGNED → NEW
Blocks: 181464
BeOS-only change to build using gcc code from bug 140412.  Builds/tests OK under BeOS with gcc 2.95.3.
Attachment #303423 - Attachment is obsolete: true
Attachment #303611 - Flags: superreview?
Attachment #303611 - Flags: superreview? → superreview?(benjamin)
Comment on attachment 303611 [details] [diff] [review]
Same as before but without the extra blank line.

cancelling SR request.  Per roc on developers IRC, build changes do not require superreview.
Since this is inside a BeOS-only conditional, it should be quite safe to commit.

I now need to flag to make the change in branch code.  sergei, can you help with the commit, please?
Attachment #303611 - Flags: superreview?(benjamin) → approval1.8.1.13?
Comment on attachment 303611 [details] [diff] [review]
Same as before but without the extra blank line.

Approved for the 1.8 branch before 1.8.1.13. a=ss
Attachment #303611 - Flags: approval1.8.1.13? → approval1.8.1.13+
Checking in mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v  <--  Makefile.in
new revision: 1.80.4.6; previous revision: 1.80.4.5
done 
Keywords: fixed1.8.1.13
thank you, sergei!  If we can, we should also check this in on the trunk so we don't forget.  tqh is making good progress on gcc4 builds for Haiku, so trunk may become important again sometime soon.
was going to close this "FIXED" since it is marked as a branch bug and is fixed there (comment 6), but I guess this is still open as a reminder (comment 7) so changing version to Trunk.
Version: 1.8 Branch → Trunk
sergei_d, here's another one to place in the trunk when you get a chance.  Daniel, thanks for your patience while we clean things up.
(In reply to comment #9)
> sergei_d, here's another one to place in the trunk when you get a chance. 
> Daniel, thanks for your patience while we clean things up.
> 
Is it appliable to trunk in current form?
Looks like it should be, though offset a few lines.
http://lxr.mozilla.org/seamonkey/source/xpcom/reflect/xptcall/src/md/unix/Makefile.in#106
Looks like this was fixed a while ago.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.