417605 - Change BeOS to invoke improved code

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Doug Shelton]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.12) Gecko/20080209 BonEcho/2.0.0.12
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.12) Gecko/20080209 BonEcho/2.0.0.12

It appears the improved code introduced in Bug 140412 was never tried/tested under BeOS.  I'm opening this bug to track my attempt to build with and test this code.

Reproducible: Always

Comment 1

[Doug Shelton]

Attachment: Changes BeOS to use newer code

Firefox builds and runs using newer code under BeOS (Zeta).

Comment 2

[tqh]

Comment on attachment 303423 [details] [diff] [review]
Changes BeOS to use newer code

r=[e-mail]

It would be nice to see what thought any expert on this might have.

Comment 3

[Doug Shelton]

Attachment: Same as before but without the extra blank line.

BeOS-only change to build using gcc code from bug 140412.  Builds/tests OK under BeOS with gcc 2.95.3.

Comment 4

[Doug Shelton]

Comment on attachment 303611 [details] [diff] [review]
Same as before but without the extra blank line.

cancelling SR request.  Per roc on developers IRC, build changes do not require superreview.
Since this is inside a BeOS-only conditional, it should be quite safe to commit.

I now need to flag to make the change in branch code.  sergei, can you help with the commit, please?

Comment 5

[Samuel Sidler (old account; do not CC)]

Comment on attachment 303611 [details] [diff] [review]
Same as before but without the extra blank line.

Approved for the 1.8 branch before 1.8.1.13. a=ss

Comment 6

[Sergei Dolgov]

Checking in mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v  <--  Makefile.in
new revision: 1.80.4.6; previous revision: 1.80.4.5
done 

Comment 7

[Doug Shelton]

thank you, sergei!  If we can, we should also check this in on the trunk so we don't forget.  tqh is making good progress on gcc4 builds for Haiku, so trunk may become important again sometime soon.

Comment 8

[Daniel Veditz [:dveditz]]

was going to close this "FIXED" since it is marked as a branch bug and is fixed there (comment 6), but I guess this is still open as a reminder (comment 7) so changing version to Trunk.

Comment 9

[Doug Shelton]

sergei_d, here's another one to place in the trunk when you get a chance.  Daniel, thanks for your patience while we clean things up.

Comment 10

[Sergei Dolgov]

(In reply to comment #9)
> sergei_d, here's another one to place in the trunk when you get a chance. 
> Daniel, thanks for your patience while we clean things up.
> 
Is it appliable to trunk in current form?

Comment 11

[Doug Shelton]

Looks like it should be, though offset a few lines.
http://lxr.mozilla.org/seamonkey/source/xpcom/reflect/xptcall/src/md/unix/Makefile.in#106

Comment 12

[Andrew McCreight [:mccr8]]

Looks like this was fixed a while ago.