417840 - "ASSERTION: Shouldn't be observing anymore" removing 'ref' attribute

Status: VERIFIED FIXED

(Core :: XUL, defect, P1)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase triggers:

###!!! ASSERTION: Shouldn't be observing anymore!: '!mObservedDocument', file /Users/jruderman/trunk/mozilla/content/xul/templates/src/nsXULTemplateBuilder.cpp, line 240

This assertion was added by bent in bug 416939.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Fix call chain, v1

This makes sure that we always remove the observer properly and consolidates the calls to the observer service. I just removed the warning about the null document because it doesn't seem to matter.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #1)
> I just removed the warning about the null document

Er, no I didn't. Different bug.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed.

Comment 5

[Jesse Ruderman]

Crashtest checked in.

Comment 6

[Boris Zbarsky [:bzbarsky]]

See bug 423355 comment 15 and on.

Comment 7

[Carsten Book [:Tomcat]]

verified fixed using the testcase and  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050621 Firefox/3.0pre - no assertion on testcase

--> Verified fixed