Closed Bug 418031 Opened 14 years ago Closed 14 years ago

Format Text Buttons in Mail Composer Windows Lose Focus and Don't Work

Categories

(Core :: Widget: Cocoa, defect, P1)

PowerPC
macOS
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: jay+MOZILLA, Assigned: smichaud)

Details

(Keywords: regression)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008021612 Firefox/3.0b4pre
Build Identifier: version 3.0a1pre (2008021622)

As in Bug 357535 and Bug 411204. Specific cause looks like r 1.306 of /mozilla/widget/cocoa/nsChildview.mm rev 1.306 (smichaud%pobox.com 2008-02-13 07:57). I reverted to 1.305 in my src and now everything is working again in Thunderbird when I click the format bar.


Reproducible: Always

Steps to Reproduce:
1. Highlight text in Thunderbird Message Compose.
2. Click any button on the Format Tool Bar
Actual Results:  
Once you click on the Format Bar the Message Compose loses focus and the Format Action (Bold, Italics, etc) does not take effect on the selected text.

Expected Results:  
Formatting is applied focus remains the same.
Flags: blocking-thunderbird3?
Keywords: mail4, regression
Assignee: nobody → joshmoz
Component: Message Compose Window → Widget: Cocoa
Flags: blocking-thunderbird3?
Keywords: mail4
Product: Thunderbird → Core
QA Contact: message-compose → cocoa
Version: unspecified → Trunk
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking1.9?
I've just posted a patch for bug 404433 that also fixes this bug (at
least in my tests).  Please try it out.

If need be I can upload a Thunderbird build made using this patch to
my people.mozilla.com account and provide a URL for that here.

Presuming I've figured out how to do a universal build of Thunderbird
:-)
> Presuming I've figured out how to do a universal build of
> Thunderbird :-)

No, I haven't.

Or rather, I haven't figured out how to build Thunderbird so that I
can make an installer.  If I build without --enable-static and
--disable-shared the installer refuses to build.  If I build with them
I get a bunch of linker errors.
I'm checking out now, applying your patch, then building. I'll post results in about 20 minutes... or maybe a little bit more. :)
Patch works great for the Thunderbird focus problem. Thanks Steven!
You're most welcome!
Flags: blocking1.9? → blocking1.9+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → NEW
Priority: -- → P1
Assignee: joshmoz → smichaud
I just landed a patch for bug 404433 that also fixes this bug.
Status: NEW → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Looks great! Thanks!
You need to log in before you can comment on or make changes to this bug.