Closed
Bug 418598
Opened 17 years ago
Closed 8 years ago
Make Error Console use richlistbox/richlistitems
Categories
(Toolkit Graveyard :: Error Console, defect)
Toolkit Graveyard
Error Console
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: adelfino, Unassigned)
References
Details
(Keywords: polish, Whiteboard: [polish-easy][polish-visual])
Attachments
(1 file)
192.28 KB,
image/png
|
Details |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008022003 Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008022003 Minefield/3.0b4pre
In /chrome/classic/skin/classic/global/console/console.css, the selected item background color is hard-coded to a provided image:
background-image: url("chrome://mozapps/skin/shared/itemSelected.png");
This makes the selection look like in the screen shot, which is awful.
Reproducible: Always
Reporter | ||
Updated•17 years ago
|
Flags: blocking-firefox3?
Version: unspecified → Trunk
Reporter | ||
Comment 1•17 years ago
|
||
Reporter | ||
Comment 2•17 years ago
|
||
Note that his is the only file which seems to use that image, so it could be deleted.
To check that, I did:
# This extracts every jar.
for i in `find . -name "*.jar"`; do unzip -d "${i%.jar}" "${i}"; done
# This greps every file for the image name.
grep -FIRi 'itemSelected.png' .
Reporter | ||
Comment 3•17 years ago
|
||
Could someone please confirm this?
Reporter | ||
Updated•17 years ago
|
Summary: Hard-coded selected item background color in Error Console → Fixed image for selected item in Error Console
Reporter | ||
Updated•17 years ago
|
Summary: Fixed image for selected item in Error Console → Fixed background image for selected item in Error Console
Comment 4•17 years ago
|
||
This will not block the final release of Firefox 3.
Flags: blocking-firefox3? → blocking-firefox3-
Comment 5•17 years ago
|
||
IIRC itemSelected was also used for the selected background for the category header icons in the preferences and addons dialogs. We removed it there and use the selection color from GTK now.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 6•16 years ago
|
||
uiwanted: merge this with the other rich list view bugs (download manger, addons manager, awesome bar) all should have the same appearance.
Keywords: uiwanted
Comment 7•16 years ago
|
||
Duping to a central bug to get this figured out on all platforms for all rich list views.
Reporter | ||
Comment 8•15 years ago
|
||
As per bug 426727 comment 17.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Summary: Fixed background image for selected item in Error Console → Make Error Console use richlistbox/richlistitems
Comment 9•15 years ago
|
||
This work is being done in bug 305206, there's a patch there already for this.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 15 years ago
Resolution: --- → DUPLICATE
Comment 10•15 years ago
|
||
(In reply to comment #9)
> This work is being done in bug 305206, there's a patch there already for this.
Then this bug depends on the other one.
Status: RESOLVED → REOPENED
Component: Theme → Error Console
Depends on: 305206
Flags: blocking-firefox3-
Product: Firefox → Toolkit
QA Contact: theme → error.console
Resolution: DUPLICATE → ---
Comment 11•8 years ago
|
||
The Error Console has been removed in favor of the Browser Console (see Bug 1278368), and the component is going to be removed. If this bug is also relevant in the Browser Console, please reopen and move this into Firefox -> Developer Tools: Console.
Status: REOPENED → RESOLVED
Closed: 15 years ago → 8 years ago
Resolution: --- → WONTFIX
Comment 12•8 years ago
|
||
I am mass-reopening and re-componenting every single one of the Toolkit:Error Console bugs that appear to have been closed without anyone even *glancing* at whether they were relevant to the Browser Console.
If you want to close a whole bunch of old bugs -- FOR ANY REASON -- it is YOUR RESPONSIBILITY to check EVERY SINGLE ONE OF THEM and make sure they are no longer valid. Do not push that work onto the bug reporters.
(It's okay to close bugs that haven't been touched in years when they don't have enough information for you to figure out whether the problem is still relevant to the current software - the reporter probably isn't coming back to clarify. But that is the ONLY situation where it is okay.)
(I'm going to have to do this in two steps because of the way the "change several bugs at once" form works. Apologies for the extra bugspam.)
Status: RESOLVED → REOPENED
Component: Error Console → Developer Tools: Console
Product: Toolkit → Firefox
Resolution: WONTFIX → ---
Error console is gone now, and we want to remove XUL usage from DevTools is general, so WONTFIX here.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → WONTFIX
Updated•8 years ago
|
Component: Developer Tools: Console → Error Console
Product: Firefox → Toolkit
Assignee | ||
Updated•8 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•