Closed
Bug 418673
Opened 18 years ago
Closed 18 years ago
restoring the current location when clicking the identity button is jerky, because handleURLBarRevert selects the address
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 3 beta4
People
(Reporter: dao, Assigned: dao)
References
Details
(Keywords: polish)
Attachments
(1 file, 1 obsolete file)
|
1.42 KB,
patch
|
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
Restoring the current location when clicking the identity button is jerky, because handleURLBarRevert selects the address. handleURLBarRevert should do that only if the location bar is focused.
Attachment #304550 -
Flags: review?(mano)
|
Assignee | |
Updated•18 years ago
|
Assignee: nobody → dao
|
||
Comment 1•18 years ago
|
||
Comment on attachment 304550 [details] [diff] [review]
patch
The comment is a little bit misleading, "unless" should apply just to "selects".
r=mano with that fixed.
Attachment #304550 -
Flags: review?(mano) → review+
|
|
Assignee | |
Comment 2•18 years ago
|
||
Attachment #304550 -
Attachment is obsolete: true
Attachment #305156 -
Flags: approval1.9?
|
||
Comment 3•18 years ago
|
||
Comment on attachment 305156 [details] [diff] [review]
patch, comment fixed
a=beltzner
Attachment #305156 -
Flags: approval1.9? → approval1.9+
|
||
Updated•18 years ago
|
Keywords: checkin-needed
|
||
Comment 4•18 years ago
|
||
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v <-- browser.js
new revision: 1.975; previous revision: 1.974
done
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4
You need to log in
before you can comment on or make changes to this bug.
Description
•