Closed Bug 406779 Opened 14 years ago Closed 14 years ago
Clicking site/identity button should restore location bar contents
In bug 397594, beltzner suggested a follow up bug to track the idea that clicking on the site button ("identity-box" in browser.xul) should restore the location bar in the case where any edits have been made, to prevent confusion in the case where you are viewing SiteA, but have edited the location bar to point to SiteB. This function is currently accomplished (at least on Mac) via hitting Esc.
Sorry for stealing this bug, Johnathan! :-) This simple patch fixes this problem.
Assignee: johnath → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #303071 - Flags: review?(mano)
(In reply to comment #1) > Sorry for stealing this bug, Johnathan! :-) > > This simple patch fixes this problem. No apology necessary, Ehsan. You've been doing some great work lately, thanks!
Comment on attachment 303071 [details] [diff] [review] Patch (v1) r=mano
Attachment #303071 - Flags: review?(mano) → review+
Comment on attachment 303071 [details] [diff] [review] Patch (v1) This patch has a simple implementation, but results in a big win by keeping the information in the identity dialog in sync with those in the URL bar. Seeking approval to land this.
Attachment #303071 - Flags: approval1.9?
Target Milestone: --- → Firefox 3 beta4
I'll check this in today.
Checking in browser/base/content/browser.js; /cvsroot/mozilla/browser/base/content/browser.js,v <-- browser.js new revision: 1.967; previous revision: 1.966 done Thanks Ehsan, I appreciate your work on this stuff.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022504 Minefield/3.0b4pre Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022504 Minefield/3.0b4pre ID:2008022504
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.