63.62 KB, image/png
77.30 KB, image/png
38.75 KB, image/jpeg
2.56 KB, patch
|Details | Diff | Splinter Review|
63.62 KB, image/png
Created attachment 305303 [details] Screenshot of resized Page Info Window on Linux Open Page info and resize the window: * on Mac Os X and Windows parameter values are cut and not fully displayed (also, for example, address in General panel) * on Linux (Gnome) situation is worse (all controls are cut)
The issue you outlined on the Mac screenshot seems to be bug 414211. The problem you get on Linux is caused by one of the other tab that doesn't resize well. All the tabs have the width of the larger one so a single tab not resizing correctly breaks all the others. If you try to resize the window while looking at the other tabs you should be able to figure out which element doesn't resize well.
About bug 414211 and Mac Os X: maybe you're right, but other strings are cut (in that panel the owner string, in the General panel the address and the referer address if they're too long). About the Linux one: I think it's caused by bug 418879 (page used for the screenshot is a Bugzilla Search Result, so it has a long feed URL), but also here long strings are cut.
(In reply to comment #3) > About bug 414211 and Mac Os X: maybe you're right, but other strings are cut > (in that panel the owner string This may be a bug. > in the General panel the address and the referer address if they're too long). This is the expected behavior, as urls can be very long and wrapping them would probably take a lot of vertical space. > About the Linux one: I think it's caused by bug 418879 (page used for the > screenshot is a Bugzilla Search Result, so it has a long feed URL), but also > here long strings are cut. > The Feeds and Permissions tabs don't look like good candidates because, as bug 418879 illustrates, a scrollbar appears in them when they are too large. I just gave a quick look at how Page Info resizes, two good suspects are the "Block Images from <hostname>" checkbox in the Media Tab, and the "Connection Encrypted: High-Grade Encryption (RC4 128bits)" string in the Security tab.
So we are missing a min-width for the page info dialog? The columns shouldn't hide the other ones or even the whole right side shouldn't be hidden when decreasing the window size horizontally or vertically.
(In reply to comment #5) > So we are missing a min-width for the page info dialog? Looks like it and probably also a min-height too. If the dialog is re-sized vertically the scroll bar for "Meta" on "General" tab and "Media Preview" on "Media" tab can do weird things or completely disappear. See http://imm.io/UGN for an example.
Created attachment 520171 [details] screenshot for comment6 This still happens on Build identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0) Gecko/20100101 Firefox/4.0
This is still happening on current trunk (31). There is a min-widht set by some elements, but I can't figure out which: for example on OS X in some pages (this one) I can resize the window only a bit (575px), on others I can reach 320px.
Created attachment 8396247 [details] [diff] [review] Patch for Security / Technical Details (In reply to Francesco Lodolo [:flod] from comment #8) > There is a min-widht set by some elements, but I can't figure out which: for > example on OS X in some pages (this one) I can resize the window only a bit > (575px), on others I can reach 320px. I tested Page Info resizing on the https://bugzilla.mozilla.org/show_bug.cgi?id=419253 URL. The element that seems to block resizing here for me is this long string: "Connection Encrypted: High-grade Encryption (TLS_DHE_RSA_WITH_AES_128_CBC_SHA, 128 bit keys)" at the top of the "Technical Details" section of the "Security" tab. The attached patch is all it takes to make that string wrap instead of blocking resizing; and then I can resize Page Info. The next element that blocks resizing is the "Block Images from <hostname>" checkbox of the Media tab when the hostname is long. That string also doesn't wrap.
First of all thanks for looking into this. This bug it's not just about letting resize the window, is more about not cutting elements. For example strings in the identity section don't wrap, so they're cut. The permissions tab is even worse. Besides letting all strings wrap, I have the feeling we need a per-locale minimum width (like we do on Preferences/Options).
(In reply to Francesco Lodolo [:flod] from comment #10) > For example strings in the identity section don't wrap, so they're cut. We could make them wrap. > The permissions tab is even worse. This one has scrollbars, so that should be enough to ensure the content is visible at small sizes. There's something strange happening right now with these scrollbars when the window is very narrow. > Besides letting all strings wrap, I have the feeling we need a per-locale > minimum width (like we do on Preferences/Options). Maybe, but it's nice to be able to display that window at a small size. So I would like the per-locale minimum to be the strict minimum under which important information can no longer be displayed, ie. I don't think adding a minimum would be a reason to not fix the resizing issues.
(In reply to Florian Quèze [:florian] [:flo] from comment #11) > This one has scrollbars, so that should be enough to ensure the content is > visible at small sizes. Ouch, I didn't realize that (OS X and its hiding scrollbars…). I'll try to look better at the window later and make a list of all elements that don't wrap.
So, assuming it's fine not to wrap URLs. * General-Security information for this page. Label "This website does not supply ownership information" wraps but with a line-height too big. * Security-Website Identity: values don't wrap.
just wondering, does it require more than a year for the developers to make the necessary changes and have the page info window not resized beyond a minimum point?
i would like to report that the "page info" window still truncates elements when resized to minimum possible. http://imgur.com/3ryQd26
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → INACTIVE
Still happening, at least in some sections of the page on Linux. 62.0a1 (2018-05-25) (64 bit)
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
You need to log in before you can comment on or make changes to this bug.