419292 - Resizer / Grippy / Grippie present on maximized window

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Steve England [:stevee]]

The 'Restore Down/Maximize' button I refer to is the one that appears in the middle of the three icons at the top right of any Windows window, between the [_] (minimize) and the [x] (close) buttons.

1. Make sure your desktop has no open windows on it, and nothing docked to any side of your desktop.
2. New profile, start Firefox
3a. If Firefox starts maximized, press the 'Restore Down/Maximize' button at the top right of the window twice.
3b. If Firefox does not start maximized, press the 'Restore Down/Maximize' button at the top right of the window three times.
4. Firefox should now be maximized. Observe the bottom right of the firefox window.

Expected:
- No resizer grippy should be present because the window is maximized.

Actual:
- Resizer grippy present

Works: 20080122_2055_firefox-3.0b3pre.en-US.win32
Broken: 20080122_2130_firefox-3.0b3pre.en-US.win32

Checkins to module PhoenixTinderbox between 2008-01-22 20:55 and 2008-01-22 21:30 : 
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-01-22+20%3A55&maxdate=2008-01-22+21%3A30&cvsroot=%2Fcvsroot
Caused by bug 407201 it seems.

Comment 1

[Peter van der Woude [:Peter6]]

not only that, you can actually resize a maximized window using the grippy.
The state of the minimize/maximize button changes when you change the window with the grippy from maxed to another size

Comment 2

[Mike Connor [:mconnor]]

Doesn't seem like a blocker, doesn't seem harmful in our testing, if not 100% correct.

Comment 3

[Geva Zeichner]

I've noticed that when moving your focus out of the FF window and back to it - the gripper disappears again.

Comment 4

[Michael Mak]

Can confirm all of the above with 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008042906 Minefield/3.0pre ID:2008042906

Comment 5

[Michael Mak]

Attachment: Grippie present on maxmised window

Comment 8

[Robert Johnston]

Essentially, what's happening here is that the attribute "sizemode" isn't changing to "maximized" when it happens. You can alt-tab away and alt-tab back and the value then changes, making the CSS rule(s) that depend on it work properly. What needs to happen is on maximize, update the "sizemode" attribute.

Comment 11

[Ed Hume]

Perhaps an additional clue: when Forecastfox is set to appear at the right end of the status bar, the grippy (in the Maximized window mode) appears to the left of the Forecastfox elements, but to the right of all other statusbar elements. Using Forecastsfox's context selection of Options, then canceling, will make the grippy disappear. Resizing and maximizing will cause the grippy to again appear between the normal statusbar elements and Forecastfox.

Comment 12

[Ben Lerner]

Is bug 251599 at all related (i.e., would fixing this attribute fix full-screen too)?

Comment 13

[Nickolay_Ponomarev]

Attachment: sizemode/windowState manual test

This can be used to test how window.minimize(), maximize(), restore() calls and minimizing/maximizing the window manually affects window.windowState property and the sizemode attribute (the latter is used to determine visibility of the grippy).

Comment 14

[Nickolay_Ponomarev]

Please check with the next trunk nightly - should be fixed.

Comment 15

[WildcatRay]

I am not seeing this in build Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090203 Minefield/3.2a1pre - Build ID: 20090203033842

Comment 16

[u88484]

(In reply to comment #15)
> I am not seeing this in build Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
> rv:1.9.2a1pre) Gecko/20090203 Minefield/3.2a1pre - Build ID: 20090203033842

It is still there using the same build.  You have to click the restore down button and then click the maximize button (same button) then the grippy will still show on the maximized window.

Comment 17

[WildcatRay]

Kurt,

That is exactly what I did. However, it must be an add-on that is affecting things for my main-use profile. In using a plain, unadorned profile, the bug is still present.

Sorry about that.

(In reply to comment #16)
> (In reply to comment #15)
> > I am not seeing this in build Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
> > rv:1.9.2a1pre) Gecko/20090203 Minefield/3.2a1pre - Build ID: 20090203033842
> 
> It is still there using the same build.  You have to click the restore down
> button and then click the maximize button (same button) then the grippy will
> still show on the maximized window.

Comment 18

[Nickolay_Ponomarev]

This is windows-only regression. It never worked on at least Mac (not sure about linux).

Comment 19

[alex_mayorga]

Still happens in Shiretoko nightlies on Vista too
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20090218 Shiretoko/3.1b3pre ID:20090218033015

Comment 20

[Nickolay_Ponomarev]

Bug 472258 was fixed on trunk (3.2) only, which should have fixed this issue.

comments 15&16 tested this on a build before the fix was checked in.

Comment 21

[Micah Gersten]

This seemingly is a problem on Linux as well.

Ubuntu bug:
https://bugs.launchpad.net/bugs/385816

I have this on Shiretoko 3.5 final.

Comment 22

[Luke Iliffe (Harlequin99)]

On windows 7 RC with the latest trunk when I maximize the window the grippy is present for a split second then disappears. This results in the expected behaviour of not being able to resize the maximized windows using the grippy.

(Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091009 Minefield/3.7a1pre ID:20091009051317)

Comment 23

[Jacob Bundgaard]

I'm using:
Mozilla/5.0 (Windows; U; Windows NT 6.0; da; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 GTB5 (.NET CLR 3.5.30729)
And also see this behavior, but actually it doesn't annoy me. For me, it's a feature, not a bug.
The only reason i see for changing it, is to imitate the behavior of other Windows Applications.

Would it be worth considering to keep the "bug", and actually implement it as a feature, as there's probably someone like me, who likes to resize their windows without having to click the Restore button first?

Comment 24

[Nickolay_Ponomarev]

> Would it be worth considering to keep the "bug"

Possibly, but the way it worked in Firefox 3.5 was broken (code-wise) and it's fixed already in the development version. So your suggestion is effectively a request for another change.

If you care about it a lot, you could submit it separately, try to get input from the UI people, make a patch, get it reviewed and landed. Or just implement it as an extension, which should be simpler.

Comment 25

[Jacob Bundgaard]

Okay. If a fix's already implemented, i'll not go any further with it.
After all, this is unintentional, and might confuse some people.

Comment 26

[M van Ketel]

My 2 cents: Just like Jacob I prefer this 'feature' actually I'd like to see it in the window directly if started maximized. Why would one to prefer to use 1 click and a click-drag to resize the window to its preferred size ins tead of the click-drag at once? This used to be the way in SeaMonkey 1.1.x and now it is is gone in SM 2.0 (probably following Fx) :(

Comment 27

[Nickolay_Ponomarev]

So this is fixed by bug 472258, as I said before. Marking as such.