419387 - Don't use separate page for login link

Status: VERIFIED INCOMPLETE

(support.mozilla.org :: General, defect)

Description

[Chris Ilias [:cilias]]

When logging into youtube, I noticed that they made it into a popup. It really speeds up the log in user-experience.

Comment 1

[Chris Ilias [:cilias]]

video of the youtube popup:
http://ilias.ca/sumo/2008-02-24_2324.swf

Comment 2

[David Tenser [:djst]]

Would certainly not hurt to have this. :)

Comment 3

[Paul Craciunoiu [:paulc]]

This could be even simpler if we just "display:none" a block and "display:block" it on clicking the log-in link through JS. We don't have jQuery support on SUMO, do we?

Comment 4

[Laura Thomson :laura]

We will have it once the metrics dashboard is live!

Comment 5

[Paul Craciunoiu [:paulc]]

This can be either part of 1.2 or the subsequent release. I was thinking a good place to put it (in the code) would be right after the "Log in" link in the side menu. This would degrade to contain the form on the sidebar for non-javascript users (which are a small percentage anyway). Then, through JQuery, we can have a centered modal window (http://deseloper.org/examples/modal-simple/) showing the form.
Sound good?

Comment 7

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

This uses the implementation at http://deseloper.org/read/2008/04/a-simple-modal/

Although not part of the ForumUX necessarily, this bug is listed in the PRD at https://wiki.mozilla.org/Support/ForumUX/PRD

Comment 8

[Paul Craciunoiu [:paulc]]

Pardon my confusion. I didn't see anything in this bug about Forum stuff, so I filed a generic patch. I filed a new bug (bug 504716) and updated the PRD for the ForumUX case.

Comment 9

[Laura Thomson :laura]

Comment on attachment 386471 [details] [diff] [review]
patch, v1

Eric should review this.  Don't forget to test on IE6.

Comment 10

[Paul Craciunoiu [:paulc]]

Just a note to myself: I need to do a minor update to the patch so that it posts login data to HTTPS.

Comment 11

[Paul Craciunoiu [:paulc]]

Comment on attachment 386471 [details] [diff] [review]
patch, v1

Just going through my r? list

Comment 12

[Paul Craciunoiu [:paulc]]

James: what do you think about this (having a modal window for logging in)? I'm mostly asking because patch is almost fully done except for comment 10.

Comment 13

[James Socol [:jsocol, :james]]

Attachment: non-modal example

The patch failed pretty spectacularly for me, so it'll need some work. But <faaborg>I'd rather not implement this as a modal dialog. If you look at the original example, or this example from Twitter, you'll see a great non-modal way of doing this. Modal dialogs force an interaction, either to use it or close it. This is much gentler and provides the functionality but can safely be ignored.</faaborg>

Comment 14

[Paul Craciunoiu [:paulc]]

Good stuff James, thank you!