419483 - getBoxObject for is deprecated - use getBoundingClientRect

Status: RESOLVED FIXED

(Toolkit Graveyard :: Microformats, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: Change to getBoundingClientRect

I need to switch to using getBoundingClientRect

I'm keeping the old way around so Microformats.js in FF3 resembles the one in Operator that works on FF2

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Better patch

There are cases where we come in here and ownerDocument is null. In those cases, we shouldn't be getting the bounding box because it is not valid for the entire document.

This case only happens with a particular microformat that is not in Firefox by default so I can't create a specific test for it, because that test would require that the entire page be the microformat (which only happens with hAtom/hFeed).

Note, however, that the hidden/not hiddenness of microformats is tested in the testcases that are already present.

Comment 2

[Mike Kaply [:mkaply]]

This is wrong. getBoundingClientRect returns a box with bottom/top/right/left

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Let's try again

getBoundingClientRect doesn't return a box, so I need to compute width and height.

Comment 4

[Robert Sayre]

Comment on attachment 308645 [details] [diff] [review]
Let's try again

r+ assuming this has test coverage

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 308645 [details] [diff] [review]
Let's try again

Yes, this has test coverage.

Comment 6

[Mike Kaply [:mkaply]]

Checked in.