419665 - VC9 on Vista builds a manifest file with duplicate entries

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brian Crowder]

Adding the following to my .mozconfig file (on Ted's advice) solves the problem for me.

LDFLAGS="-MANIFESTUAC:NO"

Comment 2

[TimoT]

configure sets -MANIFEST:NO now so adding LDFLAGS="-MANIFESTUAC:NO" separately is no longer necessary.

Comment 3

[(not currently active) Ted Mielczarek]

Not true. It only sets -MANIFEST:NO if you're building jemalloc, which doesn't currently build with VC9 anyway.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Sets LDFLAGS="-MANIFESTUAC:NO" in configure.in

Tested on a Vista build with Visual Studio Express 2k8 to great success.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 320287 [details] [diff] [review]
Sets LDFLAGS="-MANIFESTUAC:NO" in configure.in

You need to follow the example on the line above, and do LDFLAGS="$LDFLAGS ..." The variable can be pre-populated from the environment. Otherwise, looks good!

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Actually, when I first wrote/tested it with LDFLAGS="$LDFLAGS -MANIFESTUAC:NO" it did not work, only with just LDFLAGS="-MANIFESTUAC:NO" did it work.  Not sure what that means, but that's what my builds showed.

Comment 7

[(not currently active) Ted Mielczarek]

Hm, what does $LDFLAGS have in it at that point? You can't just drop the previous value on the ground, that's no good. (You can just stick an echo "LDFLAGS: $LDFLAGS" in there, and look in objdir/config.log)

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Now it doesn't work with either LDFLAGS="-MANIFESTUAC:NO"  or with echoing the LDFLAGS - either results in "bad file number".

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Sets LDFLAGS="$LDFLAGS -MANIFESTUAC:NO" in configure.in

Okay - this works, the trouble I was having earlier was because of not knowing to run autoconf to generate configure.  Now it's all fine.  There is nothing in $LDFLAGS prior to this being set for the record.

Comment 10

[(not currently active) Ted Mielczarek]

Right, typically LDFLAGS will be empty, but you're allowed to pass some LDFLAGS in your mozconfig or on the commandline, so you have to preserve those.

FWIW, we should get this checked into mozilla-central (once it opens), and then worry about 1.9.

Comment 11

[(not currently active) Ted Mielczarek]

Comment on attachment 321840 [details] [diff] [review]
Sets LDFLAGS="$LDFLAGS -MANIFESTUAC:NO" in configure.in

Policy is going to be to bake patches on mozilla-central first, so we'll need to wait for that to open for checkins.

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Adding -MANIFESTUAC:NO to configure.in for Vista builds

This one is for mozilla-central.

Comment 13

[(not currently active) Ted Mielczarek]

Comment on attachment 323485 [details] [diff] [review]
Adding -MANIFESTUAC:NO to configure.in for Vista builds

You don't need to request separate review for mozilla-central. You might need to coordinate landing with the sheriff for the time being, though.

Comment 14

[Reed Loden [:reed]]

Pushed as changeset 15225:00256c63e6ed.

Comment 15

[(not currently active) Ted Mielczarek]

Comment on attachment 323485 [details] [diff] [review]
Adding -MANIFESTUAC:NO to configure.in for Vista builds

I think we should get this on the 1.9.0 branch too, once that's possible.

Comment 16

[(not currently active) Ted Mielczarek]

Comment on attachment 323485 [details] [diff] [review]
Adding -MANIFESTUAC:NO to configure.in for Vista builds

Simple patch that will make building with VC9 on Vista possible out of the box.

Comment 17

[Samuel Sidler (old account; do not CC)]

Comment on attachment 323485 [details] [diff] [review]
Adding -MANIFESTUAC:NO to configure.in for Vista builds

Approved for 1.9.0.2. Please land in CVS. a=ss

Comment 18

[(not currently active) Ted Mielczarek]

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1995; previous revision: 1.1994
done