419787 - unit test boxes should pull by date (use MOZ_CO_DATE)

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Tinderboxes generally use MOZ_CO_DATE to get the source that corresponds to the exact time they report as their start time rather than picking up files that are checked in while they're pulling.  The unit test boxes don't seem to do this; looking at this log:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1204089656.1204091056.24141.gz&fulltext=1

I don't see any -D <date> in the cvs commands used to check out the source.  Compare to this:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1204087920.1204089821.21314.gz&fulltext=1

which does pass MOZ_CO_DATE to client.mk.  They should do this so the source they have more reliably corresponds to the build start times they report to tinderbox.

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

We also need this for unittests. 

The unittest machines rebuild with extra options, and we need to make sure we're testing the exact same bits as the tinderbox builds.

Comment 3

[[e-mail] (:bhearsum)]

I think this a WONTFIX for Firefox 3.0 at this point. For mozilla-central/1.9.1 it doesn't matter much because we lack a blame column. More importantly, these machines report the exact revision they have built. I'm going to close this bug under these assumptions. Please re-open if I'm way off here, though.

Comment 4

[Chris Cooper [:coop] (he/him)]

Moving closed Future bugs into Release Engineering in preparation for removing the Future component.