420028 - FUEL: browser_Extensions.js test requires DOM Inspector

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Justin Dolske [:Dolske]]

Test failures on Windows today:

FAIL - Check extension for existance - chrome://mochikit/content/browser/browser/fuel/test/browser_Extensions.js
FAIL - Exception thrown - TypeError: inspector is null - chrome://mochikit/content/browser/browser/fuel/test/browser_Extensions.js

I assume the other platforms haven't hit this because they haven't clobbered yet.

I'm disabling this test (browser/fuel/test/browser_Extensions.js), because there doesn't seem to be an obvious was to fix it offhand.

Comment 1

[Dave Townsend [:mossop]]

At least for the basic testing you can use the default theme which should always be present. Though you can't enable/disable it.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: Get basic Extensions tests re-enabled

This patch re-enables Extensions tests and does the most basic testing that can be done without an extension present. This will at least catch bugs like bug 426175.

I'll work on a way to get a dummy extension placed into the mochitest profile from the test folder for full testing.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 312727 [details] [diff] [review]
Get basic Extensions tests re-enabled

needed so we don't regress things like bug 426175, which these minimal tests do catch.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Now that bug 426175 is fixed, we can land these tests to make sure it doesn't regress

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 312727 [details] [diff] [review]
Get basic Extensions tests re-enabled

a1.9=beltzner

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

/cvsroot/mozilla/browser/fuel/test/browser_Extensions.js,v  <--  browser_Extensions.js
new revision: 1.5; previous revision: 1.4
done


But I am leaving this bug open until we find a way to "inject" a dummy extension into the mochitest profile

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Resolving FIXED, followup bug needed.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

I filed bug 433075.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Oops, didn't realize you had filed bug 433032.