42009 - DnD url to Windows desktop should ensure a valid filename

Status: RESOLVED DUPLICATE of bug 78509

(Core :: XUL, defect, P3)

Description

[Chris Hill]

The title of a document is used as the filename when dragging from the browser 
(link proxy icon for example) to the Windows desktop.  The title may not be a 
valid filename, so it should be converted to one before passing it as a 
filename.

In particular:
< > : " / \ |
and any control characters (< 32) should be converted to a safe character like 
space or deleted.

Another thing to consider is if the filename is the same as a system device like 
aux, con, prn, etc.

Comment 1

[Peter Trudelle]

assigning to pinkerton, nominating for nsbeta2

Comment 2

[Mike Pinkerton (not reading bugmail)]

anticipating nsbeta2+

Comment 3

[leger]

Thought we were not doing Dnd to desktop...trudelle?

Comment 4

[Peter Trudelle]

That feature (bug 37410) was granted nsbeta2+ [6/22] status at a PDT triage 
session I attended 10 days ago.  We had a fix from an external contributor, but 
found equivalent code elsewhere in mozilla that had already been tested.  I'd 
expect that we already have code that flags invalid file names to fix this bug, 
too.

Comment 5

[Mike Pinkerton (not reading bugmail)]

this is dependent on 41985, which probably won't be fixed until beta3.
nominating for beta3.

Comment 6

[Mike Pinkerton (not reading bugmail)]

pushing out, marking helpwanted.

Comment 7

[:deanis74]

I'm in!  (After being the best man at a wedding in Vegas next Tuesday, of 
course)

Comment 8

[Mike Pinkerton (not reading bugmail)]

*** Bug 51046 has been marked as a duplicate of this bug. ***

Comment 9

[Blake Ross]

I expect this is pretty easy so perhaps Dean and I can work out a fix when I 
get back (Tuesday)

Comment 10

[takagix]

Japanese SJIS(shift jis) multibyte-character ranges
0x0020-0x00ff,0x8140-0xfcff,
so please be careful not to use simple method like 's/\\/./g'.

Comment 11

[:deanis74]

Blake, I can't recall us ever looking at this.  Whenever you're up for it, let 
me know.

Comment 12

[:deanis74]

If we remove ':', I think we'll remove the possibility of coming up with a valid
device name, as most end with a colon (eg. "lpt1:").  I can do this, but I want
to make sure that I've got all characters considered.  The original bug is to
change < > : " / \ | any character < 32.  I'm not sure what to make of the
Japanese SJIS comment from takagix, though.

Comment 13

[:deanis74]

Attachment: cvs diff -u nsDataObj.cpp

Comment 14

[:deanis74]

Here's an initial implementation, to get people talking.  Any invalid character 
is replaced with a single space.  I grabbed the list of invalid characters from 
the mozclassic code.

This doesn't handle unicode, but neither does the rest of the function.  
invalidChars could be localized, but my suspicion is that they're the same on 
all Windows locales.

Comment 15

[:deanis74]

anyone have any thoughts?

Comment 16

[:deanis74]

*** This bug has been marked as a duplicate of 78509 ***