420405 - Download triggered by <iframe src="...exe"> fails if containing page has refreshed

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect, P1)

Description

[David Maza]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3

Visit a page with a META Redirect on 0 seconds, with an iFrame pointing to an exe file. 

Reproducible: Always

Steps to Reproduce:
1. Create a HTML page with an iframe to an .exe file and a META redirect in 0 seconds
2. Visit it in Firefox 3.0
3. You'll be presented with a Download window, with the option to Save Now or to Cancel. IF you click Save Now after the redirection then the download will not start. IF you click Save Now before the redirection then the download will start. This never happened with Firefox 2.0
Actual Results:  
You'll be presented with a Download window, with the option to Save Now or to Cancel. IF you click Save Now after the redirection then the download will not start. IF you click Save Now before the redirection then the download will start. This never happened with Firefox 2.0

Expected Results:  
Download starts, but you need good timing.

Comment 1

[David Maza]

Anyone?

Comment 2

[David Maza]

http://s2.photobucket.com/albums/y17/quick_6066/?action=view&current=Movie-4.flv

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

I can reproduce with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008032204 Minefield/3.0b5pre; I think we might have an existing bug on this, though I'll have to check.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

in-litmus+

https://litmus.mozilla.org/show_test.cgi?id=5215

Thanks for the excellent bug and testcase, David!

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Can we get a regression range here?

Comment 6

[Ria Klaassen (not reading all bugmail)]

Regression window is 
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-11-05+08%3A00&maxdate=2006-11-05+14%3A00
Bug 353560 seems the most likely cause.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Thanks, Ria. Mano: any thoughts?

Comment 8

[Shawn Wilsher :sdwilsh]

Trying to assign a priority to this.  How common is this in real life?

Comment 9

[Shawn Wilsher :sdwilsh]

Mano?

Comment 10

[David Maza]

Any updates?

Comment 11

[Asaf Romano (gone)]

Attachment: patch

Comment 12

[Mike Connor [:mconnor]]

Comment on attachment 315512 [details] [diff] [review]
patch

r+a=mconnor

Please do explain why we can't use the timeout here, but this is the right impl in any case.

Comment 13

[Shawn Wilsher :sdwilsh]

um, test please?  This shouldn't be hard to do with the browser chrome test suite...

Comment 14

[Shawn Wilsher :sdwilsh]

IMO, this shouldn't land without a test per toolkit testing requirements especially since this shouldn't be hard to test.

Comment 15

[Asaf Romano (gone)]

I don't know how (In reply to comment #12)
> (From update of attachment 315512 [details] [diff] [review])
> r+a=mconnor
> 
> Please do explain why we can't use the timeout here, but this is the right impl
> in any case.
> 

Because the opener is closed/refreshed.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

The opener should be a chrome window, and the location of the content window withing that shouldn't affect it, right?

Comment 17

[Asaf Romano (gone)]

no, the opener is the content window which invoked the dialog.

Comment 18

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Might this fix bug 429224 also?

Comment 19

[Mike Connor [:mconnor]]

ben, its possible, yeah, but dunno for sure.

I think we can land this without a test for now, I don't current know of a good way to trigger the dialog response via the testsuite, and that's the interaction we need to test, so I'm going to exempt this for now (and note that in-testsuite? is set already).

Comment 20

[Asaf Romano (gone)]

mozilla/toolkit/mozapps/downloads/src/nsHelperAppDlg.js.in 1.67

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008041904 Minefield/3.0pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008041904 Minefield/3.0pre

-and-

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008041907 Minefield/3.0pre