Closed
Bug 420449
Opened 17 years ago
Closed 16 years ago
Enable shift + drag for folders in bookmarks toolbar on Linux
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3.1b1
People
(Reporter: ojab, Assigned: mak)
References
Details
Attachments
(1 file)
987 bytes,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9b4pre) Gecko/2008022921 Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9b4pre) Gecko/2008022921 Minefield/3.0b4pre
When I'm trying to drag folder, it opens like I've clicked.
Reproducible: Always
Steps to Reproduce:
1. Create folder on bookmarks toolbar.
2. Try to drag it.
Actual Results:
It opens.
Expected Results:
Should be pressed as any other bookmark to be able move it.
Updated•17 years ago
|
Version: unspecified → Trunk
Comment 1•17 years ago
|
||
Shift+drag works on Windows. Not on Linux?
Updated•17 years ago
|
Component: Bookmarks → Places
QA Contact: bookmarks → places
Assignee | ||
Comment 3•17 years ago
|
||
dragging folders does not work on linux. confirming (but maybe there are dupes around, surely there is a bug for mac filled)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 4•17 years ago
|
||
You can't drag folders or feeds in the bookmarks toolbar in Fx3rc1 on Mac 10.5.2. Using shift, command, or control in addition to mouse click does not help. Bug 404214 mentions making this work with the cmd key.
Assignee | ||
Comment 5•17 years ago
|
||
IIRC there's another bug about restore dragging with cmd drag or shift drag for Mac... that is old
Assignee | ||
Comment 6•17 years ago
|
||
Mac bug is bug 389914
Assignee | ||
Comment 7•16 years ago
|
||
Can someone on Linux check if this is fixed on 20080920033605 nightly build?
Depends on: 418671
Summary: Can't move folders on bookmark toolbar → Can't drag folders on bookmark toolbar
Assignee | ||
Comment 8•16 years ago
|
||
PS: you should use shift+drag for folders on the toolbar like on other platforms
Assignee | ||
Updated•16 years ago
|
Summary: Can't drag folders on bookmark toolbar → Enable shift + drag for folders in bookmarks toolbar on Linux
Target Milestone: --- → Firefox 3.1b1
Assignee | ||
Comment 9•16 years ago
|
||
followup to bug 418671, stupid typo :\
Updated•16 years ago
|
Attachment #339757 -
Flags: review?(mano) → review+
Comment 10•16 years ago
|
||
Comment on attachment 339757 [details] [diff] [review]
fix typo
r=mano
Assignee | ||
Comment 11•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•16 years ago
|
||
actually the problem was due to the fact the popupshowing was dismissing the drag start, so we preventDefault() on popupShowing if the user is holding the shift key.
Comment 13•16 years ago
|
||
Verified fix on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b1pre) Gecko/20081006 Minefield/3.1b1pre
Status: RESOLVED → VERIFIED
Comment 15•16 years ago
|
||
As Marco pointed out on IRC we don't have d&d tests yet. Means, we should add this d&d behavior as a testcase on Litmus.
Flags: in-litmus?
Comment 16•16 years ago
|
||
Test case https://litmus.mozilla.org/show_test.cgi?id=7454 was updated in its expected results to take this bug into account for regression testing.
Flags: in-litmus? → in-litmus+
Comment 17•16 years ago
|
||
Huh, Marco I have a question. Haven't we removed the need of using the shift key for dragging folders on the toolbar for each OS now?
Assignee | ||
Comment 18•16 years ago
|
||
(In reply to comment #17)
> Huh, Marco I have a question. Haven't we removed the need of using the shift
> key for dragging folders on the toolbar for each OS now?
only on trunk
Comment 19•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•