420454 - Drop nsISupportsArray usage from nsSmtpService

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix (diff -w)

Here's another patch for dropping nsISupportsArray usage. This time from nsISmtpService and a few internal uses in nsSmtpService and nsSmtpDataSource.

xpcshell test for most of nsSmtpService included.

Note for nsSmtpDataSource::mServerArcsOut and nsSmtpDataSource::mServerRootArcsOut I have set the size at construction time because we know they will be a fixed size. This should save reallocations and time when constructing/filling them.

nsSmtpDataSource also has an mObserver, this is only used for Add and Remove, but I didn't want to remove the mObserver member variable as the documentation says that we should hold strong references to the observers. So I've just modified it not to use nsISupportsArray.

I did some whitespace tidy up as well as the functions seemed to warrant it.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix (normal patch)

Comment 2

[[e-mail]]

I'm not sure we actually use nsSmtpDataSource. I hope not ;-)

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> I'm not sure we actually use nsSmtpDataSource. I hope not ;-)

See bug 420503. I think I can probably just drop those changes, or we can commit them anyway depending on when the two patches are reviewed relative to each other.

Comment 4

[[e-mail]]

Comment on attachment 306724 [details] [diff] [review]
The fix (diff -w)

OK, r=me on the nsSmtpServer changes.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 306724 [details] [diff] [review]
The fix (diff -w)

Ignore the nsSmtpDataSource changes, I'll just drop them from the patch once bug  	420503 is committed.

Comment 6

[David :Bienvenu]

Comment on attachment 306724 [details] [diff] [review]
The fix (diff -w)

nice.

I think the redirector stuff is going away - don't know if that's going to cause conflicts or not.

Comment 7

[Mark Banner (:standard8)]

Patch checked in, I adjusted for the redirector and nsSmtpDataSource removals.