Remove |nsISupportsArray| usage in mailnews

RESOLVED FIXED in Thunderbird 55.0

Status

RESOLVED FIXED
12 years ago
2 years ago

People

(Reporter: nick.kreeger, Assigned: aceman)

Tracking

(Blocks: 1 bug, {meta})

Trunk
Thunderbird 55.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
Since the |nsISupportsArray| class is now obsolete, we should switch over and start using the |nsIArray| class.
OS: Mac OS X → All
Hardware: Macintosh → All
Depends on: 397533
Depends on: 403894
Depends on: 404492
Depends on: 406198
Depends on: 407956
Depends on: 408713
Depends on: 408731
Depends on: 410177
Depends on: 413230
Depends on: 419038
Depends on: 420454
Depends on: 420616
Blocks: 420769
Blocks: 407295
Depends on: 434493
Depends on: 436086
Depends on: 436089
Product: Core → MailNews Core

Updated

11 years ago
Depends on: 453706

Updated

11 years ago
Depends on: 454103
Depends on: 476628
Keywords: meta
Blocks: 792209
Depends on: 820377
Depends on: 821236
(Assignee)

Updated

6 years ago
Depends on: 821253
(Assignee)

Updated

6 years ago
Depends on: 821743
(Assignee)

Updated

6 years ago
Depends on: 822131
(Assignee)

Updated

6 years ago
Depends on: 831993
(Assignee)

Updated

6 years ago
Depends on: 833949
(Assignee)

Updated

6 years ago
Depends on: 833988
(Assignee)

Updated

6 years ago
Blocks: 834020
(Assignee)

Updated

6 years ago
No longer blocks: 834020
(Assignee)

Updated

6 years ago
Blocks: 834911
(Assignee)

Updated

6 years ago
No longer blocks: 834911
(Assignee)

Updated

6 years ago
Depends on: 838805
(Assignee)

Updated

6 years ago
Depends on: 840230
(Assignee)

Updated

6 years ago
Depends on: 437711
(Assignee)

Updated

6 years ago
Depends on: 856478
(Assignee)

Updated

6 years ago
Depends on: 857230
Depends on: 945045
(Assignee)

Updated

3 years ago
Depends on: 1272872
(Assignee)

Updated

3 years ago
Depends on: 1272893
(Assignee)

Updated

3 years ago
Depends on: 1273001
(Assignee)

Updated

3 years ago
Depends on: 1304802

Updated

2 years ago
Depends on: 1317871
(Assignee)

Updated

2 years ago
Depends on: 1318185

Updated

2 years ago
No longer depends on: 437711

Updated

2 years ago
Depends on: 1318806
(Assignee)

Updated

2 years ago
Depends on: 1320453
(Assignee)

Updated

2 years ago
Depends on: 1326494
(Assignee)

Comment 2

2 years ago
Once the blocking bugs are done, we can remove the nsISupportsArray from iteratorUtils:
base/util/iteratorUtils.jsm: *   nsISupportsArray
base/util/iteratorUtils.jsm:  // Try an nsISupportsArray.
base/util/iteratorUtils.jsm:  if (aEnum instanceof Ci.nsISupportsArray) {
base/util/iteratorUtils.jsm:  if (aInterface.equals(Ci.nsISupportsArray)) {
base/util/iteratorUtils.jsm:    Deprecated.warning("nsISupportsArray object is deprecated, avoid creating new ones.",
base/util/iteratorUtils.jsm:                                  .createInstance(Ci.nsISupportsArray);
base/test/unit/test_iteratorUtils.js:  let nsISupportsArray = iteratorUtils.toXPCOMArray(nsIArray, Ci.nsISupportsArray);
base/test/unit/test_iteratorUtils.js:  do_check_eq(nsISupportsArray.Count(), 5);
base/test/unit/test_iteratorUtils.js:  for (let val in iteratorUtils.fixIterator(nsISupportsArray)) {

This support was only kept for addon-compatibility but is no longer used in base TB. If m-c removes support for nsISupportsArray we have no choice than just to remove it from here too as the Ci.nsISupportsArray will probably throw.
Assignee: nobody → acelists
(Assignee)

Comment 3

2 years ago
Posted patch patchSplinter Review
m-c has removed nsISupportsArray now so we must do this.
Attachment #8845188 - Flags: review?(jorgk)
(Assignee)

Updated

2 years ago
No longer blocks: 420769
Depends on: 420769

Comment 4

2 years ago
Comment on attachment 8845188 [details] [diff] [review]
patch

Fine by me upon visual inspection ;-)
Attachment #8845188 - Flags: review?(jorgk) → review+

Comment 5

2 years ago
https://hg.mozilla.org/comm-central/rev/eadb929f668904e88c5dccfdb220b67f9256cc9c
I guess we're done here.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
(Assignee)

Comment 6

2 years ago
Thanks.
(Assignee)

Comment 7

2 years ago
Posted patch patch 2Splinter Review
Sorry, missed nsIEnumerator going away too. We just mention it in a comment.
Attachment #8845271 - Flags: review?(jorgk)

Comment 8

2 years ago
Comment on attachment 8845271 [details] [diff] [review]
patch 2

Sure, thanks.
Attachment #8845271 - Flags: review?(jorgk) → review+
You need to log in before you can comment on or make changes to this bug.