420508 - IA2Marshall.dll isn't included in packages-static

Status: RESOLVED WONTFIX

(Core :: Disability Access APIs, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Attachment: Browser patch

I noticed recently that while AccessibleMarshal.dll is included in packages-static, IA2Marshall.dll isn't. It seems to me that if one's included, so should the other.

The attached patch fixes it for the Windows packages-static in /browser. I suppose this would have to be done for /mail and /suite as well.

Comment 1

[Aaron Leventhal]

Now I think I remember -- we shouldn't be including it anywhere IIRC, because it's really only built for debugging purposes now. It's the assistive technology's responsibility to ship with that marshaling library, not the apps.

Pete, right?

Comment 2

[Pete Brunet]

That's correct.  The decision was that the ATs would install it in system32 and would not uninstall it.  Interestingly enough I don't have a copy on my system.  I am remembering that Rob said that JAWS runs fine without it.

Comment 3

[Aaron Leventhal]

WONTFIX because of comment 2.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 306788 [details] [diff] [review]
Browser patch

Cancelling review, given WONTFIX.

Comment 5

[Serge Gautherie (:sgautherie)]

Fwiw, bug 461888 removed 'accessible/build/accessibility.pkg' "in the meantime".

***

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1265531400.1265539193.4910.gz&fulltext=1
WINNT 5.2 comm-central-trunk nightly on 2010/02/07 00:30:00
{
make package-compare

 bin/AccessibleMarshal.dll
+bin/IA2Marshal.dll
}

Iiuc,
If it's to be never included then it should not be built (automatically).
If it's a debugging tool, it should be built and packaged "ifdef DEBUG".
etc.