IA2Marshall.dll isn't included in packages-static

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
11 years ago
9 years ago

People

(Reporter: RyanVM, Assigned: aaronlev)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
Created attachment 306788 [details] [diff] [review]
Browser patch

I noticed recently that while AccessibleMarshal.dll is included in packages-static, IA2Marshall.dll isn't. It seems to me that if one's included, so should the other.

The attached patch fixes it for the Windows packages-static in /browser. I suppose this would have to be done for /mail and /suite as well.
Attachment #306788 - Flags: review?(aaronleventhal)
(Assignee)

Comment 1

11 years ago
Now I think I remember -- we shouldn't be including it anywhere IIRC, because it's really only built for debugging purposes now. It's the assistive technology's responsibility to ship with that marshaling library, not the apps.

Pete, right?

Comment 2

11 years ago
That's correct.  The decision was that the ATs would install it in system32 and would not uninstall it.  Interestingly enough I don't have a copy on my system.  I am remembering that Rob said that JAWS runs fine without it.
(Assignee)

Comment 3

11 years ago
WONTFIX because of comment 2.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
Attachment #306788 - Flags: review?(aaronleventhal)
Comment on attachment 306788 [details] [diff] [review]
Browser patch

Cancelling review, given WONTFIX.
Fwiw, bug 461888 removed 'accessible/build/accessibility.pkg' "in the meantime".

***

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1265531400.1265539193.4910.gz&fulltext=1
WINNT 5.2 comm-central-trunk nightly on 2010/02/07 00:30:00
{
make package-compare

 bin/AccessibleMarshal.dll
+bin/IA2Marshal.dll
}

Iiuc,
If it's to be never included then it should not be built (automatically).
If it's a debugging tool, it should be built and packaged "ifdef DEBUG".
etc.
You need to log in before you can comment on or make changes to this bug.