Closed Bug 461888 Opened 11 years ago Closed 11 years ago

Remove unused PACKAGE_FILE flag?

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1b2

People

(Reporter: WeirdAl, Assigned: philor)

References

()

Details

Attachments

(4 files)

It looks like PACKAGE_FILE, according to mxr, is an unused Makefile flag.  Should it and its corresponding .pkg files be removed?
Yeah, they were a half-done attempt at distributing the packaging manifests that never got done and are now completely out of date. Remove them.
This wasn't even entertaining to create, much less to review. I highly recommend grep and find, rather than actually looking at it, as a review technique.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #345432 - Flags: superreview?(bienvenu)
Attachment #345432 - Flags: review?(bienvenu)
Attachment #345432 - Attachment description: Fix v.1 → mailnews/ fix v.1
Attachment #345446 - Flags: review?(benjamin)
Pretty sure I successfully checked out trunk-directory here...
Attachment #345453 - Flags: review?(bugzilla)
Attachment #345432 - Flags: superreview?(bienvenu)
Attachment #345432 - Flags: superreview+
Attachment #345432 - Flags: review?(bienvenu)
Attachment #345432 - Flags: review+
Comment on attachment 345453 [details] [diff] [review]
directory/ fix, v. 1 [checked in]

r=me if you apply this to hg only. These files are in hg now.
Attachment #345453 - Flags: review?(bugzilla) → review+
Comment on attachment 345432 [details] [diff] [review]
mailnews/ fix v.1 [checked in]

http://hg.mozilla.org/comm-central/rev/114d5b34fc31
Attachment #345432 - Attachment description: mailnews/ fix v.1 → mailnews/ fix v.1 [checked in]
Comment on attachment 345453 [details] [diff] [review]
directory/ fix, v. 1 [checked in]

http://hg.mozilla.org/comm-central/rev/5c72e416c07c
Attachment #345453 - Attachment description: directory/ fix, v. 1 → directory/ fix, v. 1 [checked in]
It wouldn't be nearly as embarrassing that I apparently didn't yet know that PACKAGE_VARS was part of the same thing, if not for the way I noticed *after* I'd already checked in a patch that didn't remove PACKAGE_VARS with a commit message saying that it did.
Attachment #345835 - Flags: superreview?(bienvenu)
Attachment #345835 - Flags: review?(bienvenu)
Comment on attachment 345835 [details] [diff] [review]
mailnews/ followup for PACKAGE_VARS [checked in]

thx for the patch, Phil!
Attachment #345835 - Flags: superreview?(bienvenu)
Attachment #345835 - Flags: superreview+
Attachment #345835 - Flags: review?(bienvenu)
Attachment #345835 - Flags: review+
Comment on attachment 345835 [details] [diff] [review]
mailnews/ followup for PACKAGE_VARS [checked in]

http://hg.mozilla.org/comm-central/rev/326265c9d9b8
Attachment #345835 - Attachment description: mailnews/ followup for PACKAGE_VARS → mailnews/ followup for PACKAGE_VARS [checked in]
Comment on attachment 345446 [details] [diff] [review]
mozilla-central fix v. 1 [checked in]

I didn't read the entire patch, just glanced at it and I trust it to be correct...
Attachment #345446 - Flags: review?(benjamin) → review+
Blocks: 462438
Comment on attachment 345446 [details] [diff] [review]
mozilla-central fix v. 1 [checked in]

http://hg.mozilla.org/mozilla-central/rev/d78c3cd8c9e0
Attachment #345446 - Attachment description: mozilla-central fix v. 1 → mozilla-central fix v. 1 [checked in]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
Version: unspecified → Trunk
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.