461888 - Remove unused PACKAGE_FILE flag?

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Alex Vincent [:WeirdAl]]

It looks like PACKAGE_FILE, according to mxr, is an unused Makefile flag.  Should it and its corresponding .pkg files be removed?

Comment 1

[Benjamin Smedberg]

Yeah, they were a half-done attempt at distributing the packaging manifests that never got done and are now completely out of date. Remove them.

Comment 2

[Phil Ringnalda (:philor)]

Attachment: mailnews/ fix v.1 [checked in]

This wasn't even entertaining to create, much less to review. I highly recommend grep and find, rather than actually looking at it, as a review technique.

Comment 3

[Phil Ringnalda (:philor)]

Attachment: mozilla-central fix v. 1 [checked in]

Comment 4

[Phil Ringnalda (:philor)]

Attachment: directory/ fix, v. 1 [checked in]

Pretty sure I successfully checked out trunk-directory here...

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 345453 [details] [diff] [review]
directory/ fix, v. 1 [checked in]

r=me if you apply this to hg only. These files are in hg now.

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 345432 [details] [diff] [review]
mailnews/ fix v.1 [checked in]

http://hg.mozilla.org/comm-central/rev/114d5b34fc31

Comment 7

[Phil Ringnalda (:philor)]

Comment on attachment 345453 [details] [diff] [review]
directory/ fix, v. 1 [checked in]

http://hg.mozilla.org/comm-central/rev/5c72e416c07c

Comment 8

[Phil Ringnalda (:philor)]

Attachment: mailnews/ followup for PACKAGE_VARS [checked in]

It wouldn't be nearly as embarrassing that I apparently didn't yet know that PACKAGE_VARS was part of the same thing, if not for the way I noticed *after* I'd already checked in a patch that didn't remove PACKAGE_VARS with a commit message saying that it did.

Comment 9

[David :Bienvenu]

Comment on attachment 345835 [details] [diff] [review]
mailnews/ followup for PACKAGE_VARS [checked in]

thx for the patch, Phil!

Comment 10

[Phil Ringnalda (:philor)]

Comment on attachment 345835 [details] [diff] [review]
mailnews/ followup for PACKAGE_VARS [checked in]

http://hg.mozilla.org/comm-central/rev/326265c9d9b8

Comment 11

[Benjamin Smedberg]

Comment on attachment 345446 [details] [diff] [review]
mozilla-central fix v. 1 [checked in]

I didn't read the entire patch, just glanced at it and I trust it to be correct...

Comment 12

[Phil Ringnalda (:philor)]

Comment on attachment 345446 [details] [diff] [review]
mozilla-central fix v. 1 [checked in]

http://hg.mozilla.org/mozilla-central/rev/d78c3cd8c9e0