420679 - (fx3-wsl10n-eu) Update Basque (eu) search plugins for Firefox 3

Status: VERIFIED FIXED

(Mozilla Localizations :: eu / Basque, defect)

Description

[Julen Ruiz Aizpuru]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; eu; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre
Build Identifier: 

We would like to offer users more local information in terms of search engines. Therefore, we want to change the search engines list, which doesn't really differ from the default (except the wikipedia-eu search plugin).

Now we have:
wikipedia-eu
amazon-en-GB
answers
creativecommons
eBay
google
yahoo

This becomes:
wikipedia-eu
creativecommons
google
yahoo
elebila
hitza

Removed: amazon-en-GB, answers and eBay
Added: elebila and hitza

The first is a search engine based on Windows Live Search which searches only in Basque pages. This feature is not implemented on any search engine at the moment, so this has been done in a specific site using the APIs from the search provider.
The main url is: http://elebila.eu (UI available in Basque/Spanish)

The second one is a newspaper with local information from almost all the Basque Country. Hitza would be the main site including information from all the regions covered by local 'Hitza's.
The main url is: http://hitza.info

Please, confirm us if all changes seem to be ok so that we can contact site owners in order to have their permission. After that we'll attach the appropriate patches.

Reproducible: Always

Comment 1

[Mic Berman]

Hi
removing amazon and eBay means there will be no commerce engines in the search
plug in list. The reason we have two commerce engines is to demonstrate to
users that they can search for shopping type items. It would be better to
either replace them with one Basque language version for shopping or keep one
or both of them if there is not that available.
To add elebila is cool - what I understand about your request is that this site
does a better job of searching Basque language sites. If that's the case then
we can add it as a general search engine.
Hitza.info, I tried their search but could not get it to work for me. It sounds
like a potentially useful searching tool though.

Comment 2

[Julen Ruiz Aizpuru]

Ok, we'll try to find a shopping site or keep one of the currently engines.

Elebila is a general search tool, yes. May I contact them in order to get their permission? (I suppose you'll need an english written message).

Also, I've contacted Hitza webmasters because it seems that their search tool is failing due to a mysql connection problem. In any case, you'll also need an english written approval, won't you?

Comment 3

[Mic Berman]

yes we'll need written permission by email which I can then post to this bug. BUT please do not promise anything concrete as until Hitza is working as currently, it's kind of tough to tell
and i'll need to still do a review on the final list cause it seems we will have more engine's than the usual list of 6 (which is OK but requires special attention).

Comment 4

[Mic Berman]

hi upon further review:  http://elebila.eu seems a good choice as it provides results in basque which adds value for our users.
I think we should concentrate there and not focus on hitza. Hitza is a news site and there search engine isn't great so don't think they'd be a valuable addition.

LMK what you find with shopping options.

Comment 5

[Mic Berman]

Julen can you update this bug with a patch for Google, Yahoo, CC, Elebila (general search for Basque pages), wikipedia-eu

and can confirm whether we can have one commerce based plug-in like eBay?

Comment 6

[Julen Ruiz Aizpuru]

Sorry for the delay Mic. At the moment we're discussing about a possible commerce site, so when we have made a decission I'll let you know here. Do you want to post a patch without that or do you prefer to wait until then?

By the way, did you receive the approval message from Elebila? I told them to CC you.

Comment 7

[Mic Berman]

Permission from Elebila:

----- Original Message -----
From: "Inaki Irazabalbeitia Fernandez" <>
To: "Julen" <>
Cc: mic@
Sent: Tuesday, March 18, 2008 10:34:34 AM GMT -05:00 US/Canada Eastern
Subject: Firefox 3 elebila permission

Dear Julen, 


I am very glad with your interest in integrating Elebila™ in Firefox 3.0. I think that yours is a wonderful idea. 


So, you have the permission of Eleka Ingeniaritza Linguistikoa SL to perform the integration of Elebila™ in Firefox 3.0. 


Yours sincerely, 
Inaki Irazabalbeitia Fernandez, Ph.D. 
Kudeatzailea / General Manager 
Eleka Ingeniaritza Linguistikoa, SL 
www.eleka.net 

Comment 8

[Mic Berman]

re comment #6, we have very little time left as RC1 is fast approaching so please move as quickly as possible to make the suggestion for review and then we can gain permission/build the plug-in, attached a patch, close this bug :)

Comment 9

[Julen Ruiz Aizpuru]

After our internal discussion, we're not going to add any new commerce-based plugins. So which should we keep, eBay or Amazon? It's up to us?

Comment 10

[Mic Berman]

if you have no alternative local commerce providers than i suggest you keep both ebay.es and amazon.co.uk because they are well known to users in europe and these represent (i think) the closest countries for shipping purposes. ok by you?

Comment 11

[Julen Ruiz Aizpuru]

OK by me, eBay and Amazon will be kept.

Before submitting a patch: Elebila already provides a search plugin for Firefox users. You can reach it at http://www.elebila.eu/search_plugin/
As far as I can see wikipedia-eu.xml or amazon-en-GB.xml differ on tags (they're similar to the reference shown at developer.mozilla.org[1]) with that plugin structure, e.g. the way parameters are specified or the way the icon is specified. So, do we need any kind of customization on that file? 

[1] http://developer.mozilla.org/en/docs/Creating_MozSearch_plugins

Comment 12

[Axel Hecht [:Pike]]

Julen, I think what Mic hinted at was whether it would make sense to switch from ebay.com to ebay.es for Basque.

Regarding the elibila plugin, please convert it to a MozSearch plugin. The one on their site doesn't even use the right namespaces, and the icon should really be a data url. You might look into converting the ico into a png, those are smaller in size. For the data url, http://software.hixie.ch/utilities/cgi/data/data will help.

The Url should use Param elements, too, so instead of

<Url type="text/html" template="http://elebila.eu/search/?opensearch=on&lang=eu&bilatu={searchTerms}"/>

do a 

<Url type="text/html" template="http://elebila.eu/search/>
  <Param name="opensearch" value="on"/>
  <Param name="lang" value="eu"/>
  <Param name="bilatu" value="{searchTerms}"/>
</Url>

Looks much nicer and is thus easier to review and maintain.

And reduce the child elements to ShortName, Description, InputEncoding, Image, Url, and SearchForm. All the rest is sooooo totally unused in our code, that maintaining that is just a headache.

Thanks for asking. Nevertheless, please generate a patch to both add the plugin and add it to list.txt, and request review from me by setting the 'r' flag to '?' and enter my bugmail address into the requestee field.

Comment 13

[Julen Ruiz Aizpuru]

Attachment: Addition of elebila to search plugins list

Comment 14

[Julen Ruiz Aizpuru]

Attachment: Elebila search plugin

Comment 15

[Axel Hecht [:Pike]]

Comment on attachment 313697 [details]
Elebila search plugin

r=me with the following adjustment:

>  <Image height="16" width="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8%2F9hAAAAAXNSR0IArs4c6QAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9gEBBURMCe2d1IAAAHcSURBVDjLzZM%2FaBNxFMc%2Fv8svf66JNEHbBvEvRBQLUlsEF3EQ19JRK7g5KB0cdHVxcil0cXBz7CC4KYKTgljRFgcRLLa2tQakTS53uZx39%2Fs9h4YEwaJj3%2Fh47%2FuP92DPVugF0m748q85%2FbdmmhpZufGU%2FaZEfbUu1WNVtRuA01tKUmk3fAm9QBxHoe%2Bew0aGKIx7w51WW9oNX9I4kT8URD9a0nnwgeRLEwX4Y4MMXjmB7cIbYyWY%2F0x85y1pJyYecmku%2F5RybUhpgODlKjaJGJg7T%2Br%2Fwpl5w%2Bb4ANUui7%2BxhXr2Hbl%2FhkLZpT23ROPJJ6wV0QA2TNCLLZpXXwAgGQdRfdtiLHnRbN18tSPb0QQXS4D0Q1w5qShMj7Hw%2FjF%2BtMa12izCWg9kO2lRv3eaMNzk3dJDLl2%2BjeM4OxaMgkNhAde4jJy6judto3WGpLus8pqSzXO4oSkeHGW4eosjRyf6IbqTNTa%2BLWBmX5MWMsjZYSoTtse%2Br1phefIA0fxHrDHY4SLehbAPUB4ZVHGcStiJcRyFW8jRaQYkKCRKscZQmx4nnBrFWKGQ1%2BRy2R11ux1IkqSyPvOcgchh2wYcfzSF6%2BbUf10iQDarlddsy%2FriV3KVItlsZo8%2B3W8I0dKqp%2BkcxQAAAABJRU5ErkJggg%3D%3</Image>

Remove the %3D%3 from the end of the data url, that seems to be junk and leaves me with an empty display, with those removed, I see the icon fine.

Please land this and the attachment 313696 [details] [diff] [review] with a comment referencing this bug and my review, something like "bug 420679, add elebila to Basque searchplugins, r=[e-mail]" would do.

For future reference, you could have created a single patch for both, by doing just a
cvs add elebila.xml
and then a
cvs -z3 diff -uN
where the N would include added and removed files in the patch.

The cvs add itself will not change the repository, so you can safely do that in your working copy, it will only be uploaded once you cvs ci.

Comment 16

[Mic Berman]

per comment #12, yes it'd be great to switch from ebay.com to ebay.es - thanks

Comment 17

[Julen Ruiz Aizpuru]

(In reply to comment #15)
> (From update of attachment 313697 [details])
> r=me with the following adjustment:
> 
> >  <Image height="16" width="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8%2F9hAAAAAXNSR0IArs4c6QAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9gEBBURMCe2d1IAAAHcSURBVDjLzZM%2FaBNxFMc%2Fv8svf66JNEHbBvEvRBQLUlsEF3EQ19JRK7g5KB0cdHVxcil0cXBz7CC4KYKTgljRFgcRLLa2tQakTS53uZx39%2Fs9h4YEwaJj3%2Fh47%2FuP92DPVugF0m748q85%2FbdmmhpZufGU%2FaZEfbUu1WNVtRuA01tKUmk3fAm9QBxHoe%2Bew0aGKIx7w51WW9oNX9I4kT8URD9a0nnwgeRLEwX4Y4MMXjmB7cIbYyWY%2F0x85y1pJyYecmku%2F5RybUhpgODlKjaJGJg7T%2Br%2Fwpl5w%2Bb4ANUui7%2BxhXr2Hbl%2FhkLZpT23ROPJJ6wV0QA2TNCLLZpXXwAgGQdRfdtiLHnRbN18tSPb0QQXS4D0Q1w5qShMj7Hw%2FjF%2BtMa12izCWg9kO2lRv3eaMNzk3dJDLl2%2BjeM4OxaMgkNhAde4jJy6judto3WGpLus8pqSzXO4oSkeHGW4eosjRyf6IbqTNTa%2BLWBmX5MWMsjZYSoTtse%2Br1phefIA0fxHrDHY4SLehbAPUB4ZVHGcStiJcRyFW8jRaQYkKCRKscZQmx4nnBrFWKGQ1%2BRy2R11ux1IkqSyPvOcgchh2wYcfzSF6%2BbUf10iQDarlddsy%2FriV3KVItlsZo8%2B3W8I0dKqp%2BkcxQAAAABJRU5ErkJggg%3D%3</Image>
> 
> Remove the %3D%3 from the end of the data url, that seems to be junk and leaves
> me with an empty display, with those removed, I see the icon fine.

OK.

> For future reference, you could have created a single patch for both, by doing
> just a
> cvs add elebila.xml
> and then a
> cvs -z3 diff -uN
> where the N would include added and removed files in the patch.
> 
> The cvs add itself will not change the repository, so you can safely do that in
> your working copy, it will only be uploaded once you cvs ci.

Thanks for the tip Axel :) Actually I was missing the N parameter, because I tried adding the new file with cvs add but at the time of making the diff cvs complained that no earlier revision exist on the repository (logical).

Comment 18

[Julen Ruiz Aizpuru]

(In reply to comment #16)
> per comment #12, yes it'd be great to switch from ebay.com to ebay.es - thanks

(Previous attachments commited)
May I attach a new patch for this? I could have Spanish plugin[1] for reference just changing the Description tag.

[1] http://lxr.mozilla.org/l10n/source/es-ES/browser/searchplugins/eBay-es.xml

Comment 19

[Axel Hecht [:Pike]]

Sounds like a good patch, yes.

Comment 20

[Julen Ruiz Aizpuru]

Attachment: Replace eBay for eBay-es in search plugins list

Comment 21

[Julen Ruiz Aizpuru]

Attachment: eBay-es search plugin

Comment 22

[Axel Hecht [:Pike]]

Comment on attachment 313934 [details] [diff] [review]
eBay-es search plugin

r=me, this could have been in one patch with the list.txt change, too.

Please land with check-in comment referencing this bug and my review again.

Comment 23

[Julen Ruiz Aizpuru]

(In reply to comment #22)
> r=me, this could have been in one patch with the list.txt change, too.

Well, I didn't do that because list.txt changes were already commited.

> Please land with check-in comment referencing this bug and my review again.

Landed! All done, closing this bug :)

Comment 24

[Axel Hecht [:Pike]]

Protocol handlers seem to be undiscussed in this bug. Would en-US defaults for mailto and webcal work? I see 30boxes in CVS, but not yet yahoo mail for mailto.

Comment 25

[Mic Berman]

julen

for now due to other reasons see bug 413630, we only have webcal=30boxes and mailto=Yahoo!Mail. 

Can you please add that. from another l10n bug 403017, this might be helpful,  

patch to include yahoo mail. It should look like
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/locales/en-US/chrome/browser-region/region.properties&rev=&cvsroot=/cvsroot&mark=20-34,
including the bumped defaultHandlersVersion to 1. 

Comment 26

[Julen Ruiz Aizpuru]

Attachment: Add Yahoo! Mail as the default mailto: handler

Comment 27

[Axel Hecht [:Pike]]

Comment on attachment 314362 [details] [diff] [review]
Add Yahoo! Mail as the default mailto: handler

r=me, check-in comments dance still applies. Thanks.

Comment 28

[Julen Ruiz Aizpuru]

Changes commited. I think we're all done so I close this bug.

Comment 29

[Axel Hecht [:Pike]]

Yes, VERIFIED.

The reference is http://hg.mozilla.org/users/axel_mozilla.com/l10n-src-verification/index.cgi/file/b1d510d6659d/reference/HEAD/eu/.