420882 - Validate geos better

Status: RESOLVED FIXED

(Toolkit Graveyard :: Microformats, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: Fix for problem plus tests for invalid geos

a latitude or longitude is a very defined value, so the microformats code should do a better job of knowing what is "correct"

This patch adds validation in to the geo code.

In the tests for this, I needed a way to succeed when we threw on creation. Hopefully I did this correctly.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Fix some more edge cases

Comment 2

[Mike Kaply [:mkaply]]

I'm thinking too hard.

The best way to validate if a string is going to be a valid floating point after conversion is like this:

            if (!isNaN(the_string)) {
/* It's a valid floating point */
            }

new patch coming.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Use the IsNan idea

Comment 4

[Mike Kaply [:mkaply]]

checked in.