421313 - change "Author Unknown" to "Author not verified" in add-on installer dialog

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

We actually have author information, the deal is that it's not verified by a code signing certificate. This patch changes the "(Author Unknown)" label to slightly more accurately say "(Author not verified)".

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: change to author not verified

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: author not verified (string change) v2

you'd think I'd learn to check my own stuff better before attaching ...

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 307733 [details] [diff] [review]
author not verified (string change) v2

a=beltzner

Comment 4

[Reed Loden [:reed]]

Checking in toolkit/locales/en-US/chrome/mozapps/xpinstall/xpinstallConfirm.properties;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/xpinstall/xpinstallConfirm.properties,v  <--  xpinstallConfirm.properties
new revision: 1.6; previous revision: 1.5
done
Checking in toolkit/mozapps/xpinstall/content/xpinstallConfirm.js;
/cvsroot/mozilla/toolkit/mozapps/xpinstall/content/xpinstallConfirm.js,v  <--  xpinstallConfirm.js
new revision: 1.11; previous revision: 1.10
done

Comment 5

[Patrick]

Wouldn't it be better include the author name as specified in the extension followed by the string " (unverified)" ?

Comment 7

[John J. Barton]

Yes, thanks "Author unverified" is better, but the best bet is the truth, which is as I understand it: "Extension File has no Digital Signature". Users understand what this means and it helps extension authors understand why the message appears.