421405 - Address book Tools | Import... results in XML Parsing Error

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Andy Boze]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.9b5pre) Gecko/2008030602 SeaMonkey/2.0a1pre equivalent to Firefox/2.0.0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.9b5pre) Gecko/2008030602 SeaMonkey/2.0a1pre

In SeaMonkey's address book, when I click Tools | Import..., the following error message pops up.

XML Parsing Error: undefined entity
Location: chrome://messenger/content/importDialog.xul
Line Number 72, Column 9:
        <radio value="all" id="allRadio" label="&importDialog.allTitle;"/>
--------^

Reproducible: Always

Steps to Reproduce:
1.Open Address Book
2.Click on Tools | Import...
3.
Actual Results:  
Error message pops up.

Expected Results:  
I should be able to continue with the import process.

Comment 1

[Mark Banner (:standard8)]

Regression from bug 399312

Comment 2

[Serge Gautherie (:sgautherie)]

Sure: see my bug 399312 comment 8.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Port from TB bug 399312 [Checkin: Comment 7]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b5pre) Gecko/2008032001 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

1- Fixes
{{
XML Parsing Error: undefined entity
Location: chrome://messenger/content/importDialog.xul
Line Number 73, Column 9:        <radio value="all" id="allRadio" label="&importDialog.allTitle;"/>
}}

2- Port other /mail specific parts too from bug 399312.

*- If you want to test this patch (with current Trunk code), you need to fix the 2(-3) missing entities from later bug 359255 too;
but I prefer to port that bug in a separate/later patch. (easier to track things, for me)

Comment 4

[[e-mail]]

Comment on attachment 310868 [details] [diff] [review]
(Av1) Port from TB bug 399312
[Checkin: Comment 7]

Sorry, but I don't see the point of a patch I can't test, so I don't see how splitting the patches helps in this case.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av1-test) Port from TB bug 399312

Av1, with comment 4 suggestion:

This is "WIP" for testing/review purpose only:
fixes 3 additional entity errors, from bug 359255 (which has been reopened...).

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b5pre) Gecko/2008032402 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

I noticed that trying to "import everything" hangs the wizard (only),
but I think this is unrelated to the current patch !?

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 310868 [details] [diff] [review]
(Av1) Port from TB bug 399312
[Checkin: Comment 7]

Use the Av1-test patch to test with.

Comment 7

[Reed Loden [:reed]]

Checking in mailnews/base/resources/content/mailTasksOverlay.xul;
/cvsroot/mozilla/mailnews/base/resources/content/mailTasksOverlay.xul,v  <--  mailTasksOverlay.xul
new revision: 1.35; previous revision: 1.34
done
Checking in suite/locales/en-US/chrome/mailnews/importDialog.dtd;
/cvsroot/mozilla/suite/locales/en-US/chrome/mailnews/importDialog.dtd,v  <--  importDialog.dtd
new revision: 1.11; previous revision: 1.10
done

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) Port from TB bug 359255 (1/n) [Checkin: Comment 13]

The 3 "new" entities were already tested with the Av1-test patch;
{{
XML Parsing Error: undefined entity
Location: chrome://messenger/content/importDialog.xul
Line Number 63, Column 3:
  <hbox class="box-header" id="header"

XML Parsing Error: undefined entity
Location: chrome://messenger/content/importDialog.xul
Line Number 69, Column 20:
      <description>&importDescription1.label;</description>

XML Parsing Error: undefined entity
Location: chrome://messenger/content/importDialog.xul
Line Number 81, Column 11:
          <radio value="filters" id="filtersRadio" label="&importDialog.filtersTitle;"/>
}}

the other additions should be straightforward.

***

I have not (yet) synchronized the following files, as they are quite different between SM and TB:
/migration.xul and /migration.dtd

***

I noticed that the following files do not exist (yet) in SM:
/mail/components/migration/public/nsIMailProfileMigrator.idl
/mail/components/migration/src/nsEudoraProfileMigrator.cpp
/mail/components/migration/src/nsProfileMigratorBase.cpp
/mail/components/migration/src/nsProfileMigratorBase.h

Maybe that's related to the hang I noticed before ??

Comment 9

[[e-mail]]

Is there a description string for what can be imported from Eudora somewhere that needs to be updated to include filters?

Comment 10

[Serge Gautherie (:sgautherie)]

I added all the 'filter' "keywords" from bug 359255, except the one in <migration.dtd>.

From <http://mxr.mozilla.org/seamonkey/search?string=eudora>,
{{
/suite/locales/en-US/chrome/common/help/mail_help.xhtml,

    * line 1800 -- <p>You can import address books from Netscape 6, Netscape 7, Eudora, Outlook,
    * line 1806 -- messages and settings</a> from Communicator, Eudora, Outlook, and Outlook
    * line 2774 -- Netscape Communicator, Outlook, Outlook Express, and Eudora. To import
    * line 2788 -- Express, or Eudora, begin from the Mail window:</p>
    * line 2805 -- <p>To import mail settings from Outlook, Outlook Express, or Eudora, begin from
}}
Is it what you were thinking of ?
(If yes, that would be a separate patch...)

Comment 11

[[e-mail]]

No, I was thinking that this line needs to be changed, but Thunderbird hasn't changed their version either for some reason:

http://mxr.mozilla.org/seamonkey/source/suite/locales/en-US/chrome/mailnews/eudoraImportMsgs.properties#50

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to comment #11)
> No, I was thinking that this line needs to be changed,

Right: I added bug 359255 comment 55...

Comment 13

[Reed Loden [:reed]]

Bv1:

Checking in suite/locales/en-US/chrome/mailnews/eudoraImportMsgs.properties;
/cvsroot/mozilla/suite/locales/en-US/chrome/mailnews/eudoraImportMsgs.properties,v  <--  eudoraImportMsgs.properties
new revision: 1.7; previous revision: 1.6
done
Checking in suite/locales/en-US/chrome/mailnews/importDialog.dtd;
/cvsroot/mozilla/suite/locales/en-US/chrome/mailnews/importDialog.dtd,v  <--  importDialog.dtd
new revision: 1.12; previous revision: 1.11
done
Checking in suite/locales/en-US/chrome/mailnews/importMsgs.properties;
/cvsroot/mozilla/suite/locales/en-US/chrome/mailnews/importMsgs.properties,v  <--  importMsgs.properties
new revision: 1.18; previous revision: 1.17
done

Comment 14

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008032816 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

V.Fixed.
(I'll file separate bugs for the other issues I noticed.)

Comment 15

[Serge Gautherie (:sgautherie)]

(In reply to comment #14)
> (I'll file separate bugs for the other issues I noticed.)

I filed bug 425952 as a first followup (= another bug 399312 regression).