421443 - Remove rdf dependent methods from nsIMessenger.idl

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Joey Minta]

Attachment: patch v1 [Checkin: Comment 3+9]

nsIMessenger includes several methods that require an rdf datasource as an argument.  There are perfectly good ways of making these calls from the front-end without passing in such an argument.  Moreover, most of the time these centralized methods aren't used.  I think avoiding these methods is a good thing, promoting better modularity in the code, rather than requiring everything to funnel through the central object.  Thus, I'm suggesting that we simply remove these methods, rather than reimplement them in non-rdf ways.

Again, some minor conflicts with the js-tree patch, but conflicts that make that patch simpler in the long run.

Comment 1

[David :Bienvenu]

Comment on attachment 307867 [details] [diff] [review]
patch v1
[Checkin: Comment 3+9]

looks good - there are a couple places where you don't really need local vars, like this:

+        var folder = folderResource.QueryInterface(Components.interfaces.nsIMsgFolder);
+        folder.emptyTrash(msgWindow, null);

but I'll leave that up to you...

Comment 2

[Rain [:rain1] (inactive)]

Joey, when do you think you'll land the patch? It's blocking some of the stuff in bug 435290.

If not, then will it be alright if someone else checks the patch in?

Comment 3

[Joey Minta]

Patch checked in.

For regressions, look at various folder actions, specifically:
-deleting folders
-emptying trash
-compacting folders
-renaming folders
-copying/moving messages and folders to other folders

Checking in mail/base/content/mail3PaneWindowCommands.js;
/cvsroot/mozilla/mail/base/content/mail3PaneWindowCommands.js,v  <--  mail3PaneWindowCommands.js
new revision: 1.45; previous revision: 1.44
done
Checking in mail/base/content/widgetglue.js;
/cvsroot/mozilla/mail/base/content/widgetglue.js,v  <--  widgetglue.js
new revision: 1.23; previous revision: 1.22
done
Checking in mailnews/base/public/nsIMessenger.idl;
/cvsroot/mozilla/mailnews/base/public/nsIMessenger.idl,v  <--  nsIMessenger.idl
new revision: 1.75; previous revision: 1.74
done
Checking in mailnews/base/resources/content/messengerdnd.js;
/cvsroot/mozilla/mailnews/base/resources/content/messengerdnd.js,v  <--  messengerdnd.js
new revision: 1.64; previous revision: 1.63
done
Checking in mailnews/base/resources/content/widgetglue.js;
/cvsroot/mozilla/mailnews/base/resources/content/widgetglue.js,v  <--  widgetglue.js
new revision: 1.176; previous revision: 1.175
done
Checking in mailnews/base/src/nsMessenger.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMessenger.cpp,v  <--  nsMessenger.cpp
new revision: 1.388; previous revision: 1.387
done
Checking in mailnews/base/src/nsMessenger.h;
/cvsroot/mozilla/mailnews/base/src/nsMessenger.h,v  <--  nsMessenger.h
new revision: 1.49; previous revision: 1.48
done

Comment 4

[David :Bienvenu]

This broke compacting all folders - I'll try to find a fix. 

Comment 5

[David :Bienvenu]

Attachment: fix compact all [Checkin: Comment 10]

this restores the old logic for doing a compact vs. doing a compact all.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 322948 [details] [diff] [review]
fix compact all
[Checkin: Comment 10]

Well this works fine and fixes the problem, but I don't have review privs for mail/ :-(

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 322948 [details] [diff] [review]
fix compact all
[Checkin: Comment 10]

Yes this works fine, David. r=me

Comment 8

[Eric Shepherd [:sheppy]]

Looks like this was done ages ago.

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 307867 [details] [diff] [review]
patch v1
[Checkin: Comment 3+9]


http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=ThunderbirdTinderbox&sortby=Date&hours=2&date=explicit&mindate=2008-05-26+07%3A46&maxdate=2008-05-26+07%3A46
forgot a seamonkey file for bug 421443

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 322948 [details] [diff] [review]
fix compact all
[Checkin: Comment 10]


http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/mail/base/content/widgetglue.js&rev=HEAD&mark=1.24#1.25