Closed Bug 439364 Opened 12 years ago Closed 12 years ago

Eliminate GetResourceForUri

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3

People

(Reporter: jminta, Assigned: jminta)

References

Details

Attachments

(1 file)

Attached patch patch v1Splinter Review
Nobody actually wants (or should want) the rdf resource associated with a folder.  They just want the actual nsIMsgFolder.  This function should go away. Looking for philor for the mail/ bits, and Neil for the mailnews/ side
Attachment #325203 - Flags: superreview?(neil)
Attachment #325203 - Flags: review?(philringnalda)
Comment on attachment 325203 [details] [diff] [review]
patch v1

Looks fine to me, barring the way bug 439378 was making it impossible to tell whether or not renaming folders was still working.
Attachment #325203 - Flags: review?(philringnalda) → review+
Attachment #325203 - Flags: superreview?(neil) → superreview+
Patch checked in.

Checking in mail/base/content/commandglue.js;
/cvsroot/mozilla/mail/base/content/commandglue.js,v  <--  commandglue.js
new revision: 1.94; previous revision: 1.93
done
Checking in mail/base/content/searchBar.js;
/cvsroot/mozilla/mail/base/content/searchBar.js,v  <--  searchBar.js
new revision: 1.49; previous revision: 1.48
done
Checking in mail/base/content/widgetglue.js;
/cvsroot/mozilla/mail/base/content/widgetglue.js,v  <--  widgetglue.js
new revision: 1.29; previous revision: 1.28
done
Checking in mailnews/base/resources/content/virtualFolderListDialog.js;
/cvsroot/mozilla/mailnews/base/resources/content/virtualFolderListDialog.js,v  <--  virtualFolderListDialog.js
new revision: 1.7; previous revision: 1.6
done
Checking in mailnews/base/resources/content/virtualFolderProperties.js;
/cvsroot/mozilla/mailnews/base/resources/content/virtualFolderProperties.js,v  <--  virtualFolderProperties.js
new revision: 1.18; previous revision: 1.17
done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3
Comment on attachment 325203 [details] [diff] [review]
patch v1

>diff -r 55925f6375e2 mail/base/content/widgetglue.js
>@@ -81,17 +81,17 @@ function RenameFolder(name,uri)
> function RenameFolder(name,uri)
>-      var selectedFolder = GetResourceFromUri(uri);
>+      var selectedFolder = GetMsgFolderFromUri(uri);

Ftr,
bug 506004 comment 7:
{
From  neil@parkwaycc.co.uk   2009-07-24 05:08:24 PDT

This [was] a regression from bug 421443 - the old method used an nsIRDFResource
but the new one needs an nsIMsgFolder.
}
The user facing bug would be the regression, not this one.
Keywords: regression
Depends on: 438786
Blocks: 657607
No longer blocks: 657607
You need to log in before you can comment on or make changes to this bug.