421678 - Left padding of Unified back/forward button is too small

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Unified back/forward button doesn't has left padding

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008030706 Minefield/3.0b5pre ID:2008030706

Using Aero the unified back/forward button is cut-off on the left side. There should also be a small padding of 5px like it is done on the right side for the search box. If you place another toolbar icon on the left side of the back/forward button everthing seems fine and the paddings are correct. See the attached screenshot.

Comment 1

[Dão Gottwald [:dao]]

should be fixed

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dao, it is better now. But there is still a difference between the left padding of the keyhole icon and the right padding of the search box. Both should have the same gap to the border. How it should look like could be seen by placing another toolbar button on the left of the keyhole. Tweaking the summary to better fit this issue.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

I think ideally the padding on the left side of the keyhole should match the padding above and below the keyhole.  On the right side of the browser the padding to the right of the search bar should match the padding above and below the search bar.  This is because it is visually very easy to compare nearby padding and difficult to compare the padding on the opposite sides of the browser window.  I would also make sure the padding between the location bar and search bar is the same the same as the distance between the search bar and the right side of the window, which is also the same as the padding above and below it.

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Padding mockup

Mockup of suggested padding for windows.

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

I've filed bug 422559 to track various alignment and padding issues with the windows theme.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I commented to this issue and some other things on bug 422559 comment 3. This doesn't only happen with Aero.

Comment 7

[Kai Liu]

I guess with bug 422559 fixed and a new keyhole landed, it's safe to mark this as fixed?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

IMO the right/left padding is still a bit to small. It doesn't fit smoothly with the left side of the main menu and Bookmarks Toolbar as what I can see (the latter one) under OS X. It also applies to the small icon set where you can see that it is 2px smaller. But as the mock-up shows its a desired behavior.